feat: Hold Sam clocked CV sample-and-hold to MIDI - #615
Draft
kosmar wants to merge 7 commits into
Draft
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Add MidiNote base pitch (0V ≈ base) and size gate % in PPQN ticks so holds track clock tempo instead of short fixed-ms beeps. Co-authored-by: Cursor <cursoragent@cursor.com>
Note mode dims the button for the gate; CC samples get a short duck. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
The local resolution table and the `res / 345` lookups duplicate libfp::utils::CLOCK_DIVISIONS and division_at, which also brings the bounds check this app currently does by hand. Authored by an AI coding agent on behalf of kosmar. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as_chunks::<4>()in USB MIDI RX pathTest plan
Prerequisites
The platform pieces this app needs are under review as their own PRs, so that
each app PR stays small enough to review on its own.
Required — these APIs do not exist on current
main:App::clock_ticker, which replaces theClock::get_tickerthis branch was written againstThis branch is still based on an older
mainthat still had the removed clockhelper, which is why it builds on its own but not after a rebase.
On top of the PRs above there is an app-side change:
ClockEvent::TickbecameTick(u64)in #579, so the match arm here has to be updated.Building any of this on a current Rust nightly also needs the toolchain fix in
#632.