feat: add Golden Gate app - #605
Draft
kosmar wants to merge 13 commits into
Draft
Conversation
Fibonacci-spaced gate/pitch generator (app ID 30) with speed override, output modes, and configurator manual including gesture tables.
This was referenced Jul 22, 2026
kosmar
marked this pull request as draft
July 24, 2026 14:17
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Authored by an AI coding agent on behalf of kosmar.
Co-authored-by: Cursor <cursoragent@cursor.com>
The branch still used the ID it was first drafted with. ID 30 now belongs to another app in docs/wip-app-ids.md, and 28 is reserved for Sift, so two of these app branches would have collided on merge. Authored by an AI coding agent on behalf of kosmar.
Upstream PR ATOVproject#601 asserts at compile time that CONFIG strings are pure ASCII, because postcard-bindgen JavaScript codec cannot round-trip anything else. Doc and inline comments keep their typography. Authored by an AI coding agent on behalf of kosmar.
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # faderpunk/src/tasks/midi.rs
Same mutate+save API as ATOVproject#640 so WIP apps can call params.update now. Host AppState push stays out until the real writeback lands. Authored by an AI coding agent on behalf of kosmar. Co-authored-by: Cursor <cursoragent@cursor.com>
ParamStore::update polyfill (mutate+FRAM, no host push). Authored by an AI coding agent on behalf of kosmar. Co-authored-by: Cursor <cursoragent@cursor.com>
A modulator that never reaches its rails could only nudge the target a little, since CV Att could at most pass the input through unchanged. Allowing gain up to 4x lets a tame LFO drive the destination across the full range, with the existing clamp in attenuate_bipolar turning the excess into a hold at the end stops. Stored presets keep their behaviour: the scale is linear and 100 still means unity. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fibonacci_gate): one-channel gate/pitch generator with Fibonacci gap spacing (ratios approach φ).Note: IDs 28 / 29 are reserved for Heat Pump (#603) and Grooves (#604). Independent from
main.Test plan
Prerequisites
The platform pieces this app needs are under review as their own PRs, so that
each app PR stays small enough to review on its own.
Required — these APIs do not exist on current
main:App::clock_ticker, which replaces theClock::get_tickerthis branch was written againstParamStore::update, so an app can write its own params back to the hostThis branch is still based on an older
mainthat still had the removed clockhelper, which is why it builds on its own but not after a rebase.
On top of the PRs above there is an app-side change:
ClockEvent::TickbecameTick(u64)in #579, so the match arm here has to be updated.Building any of this on a current Rust nightly also needs the toolchain fix in
#632.