Skip to content

[FEAT/#444] 학생 홈 제휴 API의 partnerProfileUrl presigned URL 누락 수정 - #445

Merged
BAEK0111 merged 1 commit into
developfrom
feat/#444-presigned-url
Sep 1, 2026
Merged

[FEAT/#444] 학생 홈 제휴 API의 partnerProfileUrl presigned URL 누락 수정#445
BAEK0111 merged 1 commit into
developfrom
feat/#444-presigned-url

Conversation

@BAEK0111

@BAEK0111 BAEK0111 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

#️⃣연관된 이슈

close #444

📝작업 내용

getUsablePartnership, getRecommendCarouselPartnership 두 API에서 partnerProfileUrl을 반환할 때 presigned URL 처리가 누락되어 있었습니다.
GET /store/{storeId}에서는 amazonS3Manager.generatePresignedUrl()로 정상 처리되고 있었으나, 위 두 메서드는 raw S3 key를 그대로 반환하고 있었습니다.
동일 클래스 내 기존 private 헬퍼 getStoreProfileImageUrl(Store)를 재사용해 일관된 presigned URL을 반환하도록 수정했습니다.

🔎코드 설명(스크린샷(선택))

StudentServiceImpl

  • getUsablePartnership: partner.getMember().getProfileUrl() 직접 반환 → getStoreProfileImageUrl(store) 호출로 교체
  • getRecommendCarouselPartnership: 동일하게 교체
  • 이제 미사용이 된 Partner partner 지역 변수 2개 및 Partner import 제거

StudentServiceImplTest

  • AmazonS3Manager mock 추가 (기존 누락)
  • usablePartnershipWithPartner() 헬퍼 추가 (partner → member → profileUrl 연결된 UserPaper 생성)
  • presigned URL 관련 테스트 4개 추가
    • getUsablePartnership: 프로필 이미지 있을 때 presigned URL 반환 / 파트너 없을 때 null 반환 검증
    • getRecommendCarouselPartnership: 동일 2케이스 검증

💬고민사항 및 리뷰 요구사항 (Optional)

특이사항 없습니다.

비고 (Optional)

GET /store/{storeId} (StoreServiceImpl.getStoreDetails)의 처리 방식을 레퍼런스로 참고했습니다.

- getUsablePartnership, getRecommendCarouselPartnership에서 raw S3 key 대신 presigned URL 반환하도록 수정
- 미사용 Partner 지역 변수 및 import 제거
- presigned URL 반환/미반환 케이스 테스트 4개 추가

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015dRXdwMUUx9e1HgamshcVo
@BAEK0111 BAEK0111 linked an issue Sep 1, 2026 that may be closed by this pull request
4 tasks
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 88aad383-fed2-4fcc-a488-a62558ea501b


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BAEK0111
BAEK0111 merged commit 820c463 into develop Sep 1, 2026
2 checks passed
@BAEK0111 BAEK0111 self-assigned this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT/#444] Presigned URL 처리

1 participant