Direct users to new webpack loader package#9
Open
strawburster wants to merge 1 commit intoAS-Devs:masterfrom
Open
Direct users to new webpack loader package#9strawburster wants to merge 1 commit intoAS-Devs:masterfrom
strawburster wants to merge 1 commit intoAS-Devs:masterfrom
Conversation
Thank you for mentioning my npm package! Unfortunately, it seems the sass compiler API is not very consistent between implementations, and the json2scss-map-webpack-importer only works with the deprecated node-sass package. Instead of adding compatibility with the newer compiler, I decided to side-step it by defining a separate webpack loader that will call json2scss-map before the sass-loader even sees anything. This should allow the new package to be compiler-agnostic, and only depend on the webpack loader API, which hasn't changed ever as far as I know, and this package's API.
strawburster
force-pushed
the
new-webpack-pkg
branch
from
7277dfa to
afc7f39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for mentioning my npm package! Unfortunately, it seems the sass compiler API is not very consistent between implementations, and the json2scss-map-webpack-importer only works with the deprecated node-sass package.
Instead of adding compatibility with the newer compiler, I decided to side-step it by defining a separate webpack loader that will call json2scss-map before the sass-loader even sees anything.
This should allow the new package to be compiler-agnostic, and only depend on the webpack loader API, which hasn't changed ever as far as I know, and this package's API.