Migrate Resonate to Feature Based MVVM with Riverpod by M4dhav · Pull Request #839 · AOSSIE-Org/Resonate

M4dhav · 2026-07-08T11:02:13Z

Description

This PR merges all state migration changes to port Resonate to Riverpod by @Mayank4352

Type of change

Please delete options that are not relevant.

Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

Tests passing

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
I have checked my code and corrected any misspellings

Maintainer Checklist

Tag the PR with the appropriate labels

feat: Refactored Auth feature to Riverpod and MVVM

* fix: Fixed the state error in app prefs page * feat: Refactor Profile feature to Riverpod and MVVM * fix: fixed broken workflow --------- Co-authored-by: Madhav Gupta <114633095+M4dhav@users.noreply.github.com>

* fix: Fixed the state error in app prefs page * feat: MIGRATED ROOMS FROM GETX TO RIVERPOD * feat: Refactor Profile feature to Riverpod and MVVM * chore: regenerate code-gen outputs after merge * fix: fixed broken workflow * fix: added left localizations & subfolders for repo and service in data * fix: fixed search overlay bug and room deleation --------- Co-authored-by: Madhav Gupta <114633095+M4dhav@users.noreply.github.com>

…827) * fix: Fixed the state error in app prefs page * feat: MIGRATED ROOMS FROM GETX TO RIVERPOD * feat: Refactor Profile feature to Riverpod and MVVM * chore: regenerate code-gen outputs after merge * feat: friends migration * fix: fixed broken workflow * fix: added left localizations & subfolders for repo and service in data * fix: fixed search overlay bug and room deleation * feat: commit for untranslated.txt --------- Co-authored-by: Madhav Gupta <114633095+M4dhav@users.noreply.github.com>

…re (#829) * fix: Fixed the state error in app prefs page * feat: MIGRATED ROOMS FROM GETX TO RIVERPOD * feat: Refactor Profile feature to Riverpod and MVVM * chore: regenerate code-gen outputs after merge * feat: friends migration * fix: fixed broken workflow * fix: added left localizations & subfolders for repo and service in data * fix: fixed search overlay bug and room deleation * feat: commit for untranslated.txt * feat: initial migartion from Stories and Chapter Logic * feat: Added tests for stories and chapters * feat: added widgte tests and fixed bugs --------- Co-authored-by: Madhav Gupta <114633095+M4dhav@users.noreply.github.com>

* fix: Fixed the state error in app prefs page * feat: MIGRATED ROOMS FROM GETX TO RIVERPOD * feat: Refactor Profile feature to Riverpod and MVVM * chore: regenerate code-gen outputs after merge * feat: friends migration * fix: fixed broken workflow * fix: added left localizations & subfolders for repo and service in data * fix: fixed search overlay bug and room deleation * feat: commit for untranslated.txt * feat: initial migartion from Stories and Chapter Logic * feat: Added tests for stories and chapters * feat: added widgte tests and fixed bugs * feat: Migrated themes, snackbar and removed the Getx dependencies * fix: fixed snackbar, static sizing and live chapter bug --------- Co-authored-by: Madhav Gupta <114633095+M4dhav@users.noreply.github.com>

* fix: Fixed the state error in app prefs page * feat: MIGRATED ROOMS FROM GETX TO RIVERPOD * feat: Refactor Profile feature to Riverpod and MVVM * chore: regenerate code-gen outputs after merge * feat: friends migration * fix: fixed broken workflow * fix: added left localizations & subfolders for repo and service in data * fix: fixed search overlay bug and room deleation * feat: commit for untranslated.txt * feat: initial migartion from Stories and Chapter Logic * feat: Added tests for stories and chapters * feat: added widgte tests and fixed bugs * feat: Migrated themes, snackbar and removed the Getx dependencies * fix: fixed snackbar, static sizing and live chapter bug * feat: Added the leftover tests after complete migration --------- Co-authored-by: Madhav Gupta <114633095+M4dhav@users.noreply.github.com>

* fix: Fixed the state error in app prefs page * feat: MIGRATED ROOMS FROM GETX TO RIVERPOD * feat: Refactor Profile feature to Riverpod and MVVM * chore: regenerate code-gen outputs after merge * feat: friends migration * fix: fixed broken workflow * fix: added left localizations & subfolders for repo and service in data * fix: fixed search overlay bug and room deleation * feat: commit for untranslated.txt * feat: initial migartion from Stories and Chapter Logic * feat: Added tests for stories and chapters * feat: added widgte tests and fixed bugs * feat: Migrated themes, snackbar and removed the Getx dependencies * fix: fixed snackbar, static sizing and live chapter bug * feat: Added the leftover tests after complete migration * refactor: post migration cleanup --------- Co-authored-by: Madhav Gupta <114633095+M4dhav@users.noreply.github.com>

github-actions · 2026-07-08T11:02:21Z

🎉 Welcome @M4dhav!
Thank you for your pull request! Our team will review it soon. 🔍

Please ensure your PR follows the contribution guidelines. ✅
All automated tests should pass before merging. 🔄
If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

coderabbitai · 2026-07-08T11:02:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 667adf0d-cf1a-42ba-97e3-def56518f2c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…rop redundant GetX edits, resolve l10n)

M4dhav

I noticed that in some places in the implementation, A view accesses multiple ViewModels and ViewModels sometimes access each other. This is not consistent with the MVVM pattern, according to which each View should have a 1-1 relationship with ViewModels, and ViewModels should only access the Repository Layer.

Please make changes to restructure the code.

M4dhav · 2026-07-08T11:10:47Z

Leave the client as a riverpod keep alive provider but for the rest of them make them static classes

I'd recommend to keep it this way only as it'll make our life vey easy while injecting them in mocks

M4dhav · 2026-07-08T11:15:42Z

Make it a static function instead of a riverpod provider

I'd recommend to keep it this way only as mentioned above

M4dhav · 2026-07-08T11:16:15Z

GetStorage isn't referenced in many places so the provider shouldn't be keepAlive

M4dhav · 2026-07-08T11:26:33Z

Making an enum for this is unnecessary as we only use this list to reference pickable audio files

M4dhav · 2026-07-08T11:26:52Z

This is also unnecessary similar to AudioFormat enums

M4dhav · 2026-07-09T09:31:37Z

This is already present in utils

M4dhav · 2026-07-09T09:44:09Z

+String _placeholderIdFor(String themeName) {
+  switch (themeName) {
+    case 'amber':
+      return amberUserProfileImagePlaceholderID;
+    case 'vintage':
+      return vintageUserProfileImagePlaceholderID;
+    case 'time':
+      return timeUserProfileImagePlaceholderID;
+    case 'classic':
+      return classicUserProfileImagePlaceholderID;
+    case 'forest':
+      return forestUserProfileImagePlaceholderID;
+    case 'cream':
+      return creamUserProfileImagePlaceholderID;
+    default:
+      return creamUserProfileImagePlaceholderID;
+  }
+}


Change themes to use an enum instead of a string

M4dhav · 2026-07-09T10:04:56Z

Move the search story functionality to explore story notifier

M4dhav · 2026-07-09T10:09:12Z

+import 'package:resonate/utils/constants.dart';
+
+// Converts the response from the createPairChat API into the parameters needed to join a LiveKit room.
+// Temporary, when the full livekit cluster is migrated, it'll be added to core


This comment mentions a migration which is never done

M4dhav · 2026-07-09T10:10:27Z

Instead of this special mapper just add these conversions to Story's freezed model

M4dhav · 2026-07-12T11:24:13Z

@Mayank4352 Please check the review comments above. Feel free to push directly to the state_migration branch for your changes now

Mayank4352 · 2026-07-14T13:28:22Z

Hey @M4dhav, Kindly review this PR

Mayank4352 and others added 12 commits May 27, 2026 18:34

feat: Refactored Auth feature to Riverpod and MVVM

7460a62

Added widget tests for refactored auth pages

0501979

fix: fixed inconsistencies

b120a7d

fix: tightened the implementation

77f13b1

Merge pull request #818 from Mayank4352/state_refactor

14491d7

feat: Refactored Auth feature to Riverpod and MVVM

Refactored Profile Logic to Feature based MVVM with Riverpod (#822)

b14fd1d

* fix: Fixed the state error in app prefs page * feat: Refactor Profile feature to Riverpod and MVVM * fix: fixed broken workflow --------- Co-authored-by: Madhav Gupta <114633095+M4dhav@users.noreply.github.com>

M4dhav assigned Mayank4352 Jul 8, 2026

M4dhav added gsoc Part of Google Summer of Code season migration labels Jul 8, 2026

chore: merge upstream/dev into state_migration (keep migrated code, d…

fe77679

…rop redundant GetX edits, resolve l10n)

M4dhav commented Jul 12, 2026

View reviewed changes

Mayank4352 added 4 commits July 14, 2026 12:47

feat: Updated Auth

3b787a2

refactor: refactored VMs

0065ab7

feat: made the requested changes

b983f80

feat: updated strings

63ab252

Uh oh!

Uh oh!

Conversation

M4dhav commented Jul 8, 2026

Description

Type of change

How Has This Been Tested?

Checklist:

Maintainer Checklist

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

coderabbitai Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

M4dhav left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

M4dhav commented Jul 12, 2026

Uh oh!

Mayank4352 commented Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Jul 8, 2026 •

edited

Loading