Skip to content

Added the leftover tests and cleaning any inconsistensies - #836

Merged
M4dhav merged 25 commits into
AOSSIE-Org:state_migrationfrom
Mayank4352:state_cleanup
Jul 8, 2026
Merged

Added the leftover tests and cleaning any inconsistensies#836
M4dhav merged 25 commits into
AOSSIE-Org:state_migrationfrom
Mayank4352:state_cleanup

Conversation

@Mayank4352

Copy link
Copy Markdown
Contributor

Description

Added the leftover tests that were intentionally left at the time of migration and cleaning any inconsistensies

Fixes #835

Type of change

  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

Tested Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

Mayank4352 and others added 20 commits May 28, 2026 12:51
fix: Fixed the state error in app prefs page
…into sate_refac_rooms

# Conflicts:
#	lib/core/legacy_dependencies.dart
#	lib/routes/app_router.dart
#	lib/views/screens/tabview_screen.dart
#	test/controllers/change_email_controller_test.dart
#	test/controllers/change_email_controller_test.mocks.dart
#	test/features/profile/data/profile_repository_test.mocks.dart
#	test/helpers/test_root_container.dart
#	test/helpers/test_root_container.mocks.dart
@Mayank4352
Mayank4352 requested a review from M4dhav as a code owner July 4, 2026 13:18
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

🎉 Welcome @Mayank4352!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c9300ffa-cfd5-4975-9671-072a03dc7b7d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mayank4352 Mayank4352 self-assigned this Jul 8, 2026
@Mayank4352 Mayank4352 added gsoc Part of Google Summer of Code season enhancement New feature or request labels Jul 8, 2026
@M4dhav
M4dhav merged commit cd5206c into AOSSIE-Org:state_migration Jul 8, 2026
3 of 4 checks passed
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

PR Closed - Thank You, @Mayank4352!

  • If this PR was merged: Congratulations! Your contribution is now part of the project. 🚀
  • If this PR was closed without merging: Don’t worry! You can always improve it and submit again. 💪

We appreciate your effort and look forward to more contributions from you! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gsoc Part of Google Summer of Code season

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants