Skip to content

Refactored Rooms logic to feature based MVVM with Riverpod#824

Merged
M4dhav merged 12 commits into
AOSSIE-Org:state_migrationfrom
Mayank4352:state_refac_rooms
Jul 8, 2026
Merged

Refactored Rooms logic to feature based MVVM with Riverpod#824
M4dhav merged 12 commits into
AOSSIE-Org:state_migrationfrom
Mayank4352:state_refac_rooms

Conversation

@Mayank4352

@Mayank4352 Mayank4352 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Description

Refactored Rooms logic to feature based MVVM with Riverpod

Fixes #823

Type of change

Please delete options that are not relevant.

  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

Tested locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

Mayank4352 and others added 11 commits May 28, 2026 12:51
@Mayank4352
fix: Fixed the state error in app prefs page
fe9bdc7
@Mayank4352
feat: MIGRATED ROOMS FROM GETX TO RIVERPOD
3a1a45c
@M4dhav
Merge pull request AOSSIE-Org#816 from Mayank4352/app_state_bug
5cb6024 
fix: Fixed the state error in app prefs page
@Mayank4352
feat: Refactor Profile feature to Riverpod and MVVM
b00d39b
@Mayank4352
Merge branch 'state_profile' of https://github.com/Mayank4352/Resonate …
5c6efa1 
…into sate_refac_rooms

# Conflicts:
#	lib/core/legacy_dependencies.dart
#	lib/routes/app_router.dart
#	lib/views/screens/tabview_screen.dart
#	test/controllers/change_email_controller_test.dart
#	test/controllers/change_email_controller_test.mocks.dart
#	test/features/profile/data/profile_repository_test.mocks.dart
#	test/helpers/test_root_container.dart
#	test/helpers/test_root_container.mocks.dart
@Mayank4352
chore: regenerate code-gen outputs after merge
1b21587
@Mayank4352
Merge branch 'dev' of https://github.com/AOSSIE-Org/Resonate into sat…
fec178e 
…e_refac_rooms
@Mayank4352
fix: fixed broken workflow
e40b06e
@Mayank4352
Merge branch 'workflow' of https://github.com/Mayank4352/Resonate int…
33497d7 
…o state_refac_rooms
@Mayank4352
fix: added left localizations & subfolders for repo and service in data
db170f8
@Mayank4352
fix: fixed search overlay bug and room deleation
be3f556
@Mayank4352 Mayank4352 self-assigned this Jun 15, 2026
@Mayank4352
Mayank4352 requested a review from M4dhav as a code owner June 15, 2026 11:51
@Mayank4352 Mayank4352 added enhancement New feature or request gsoc Part of Google Summer of Code season labels Jun 15, 2026
@coderabbitai

coderabbitai Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eda60d72-3ff2-4b8f-8c2c-60faa0a35d67

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🎉 Welcome @Mayank4352!
Thank you for your pull request! Our team will review it soon. 🔍

  • Please ensure your PR follows the contribution guidelines. ✅
  • All automated tests should pass before merging. 🔄
  • If this PR fixes an issue, link it in the description. 🔗

We appreciate your contribution! 🚀

@Mayank4352

Mayank4352 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

hey @M4dhav, Kindly review and merge

@M4dhav M4dhav mentioned this pull request Jun 18, 2026
Merged
9 tasks
@Mayank4352 Mayank4352 changed the title State refac rooms Refactored Rooms logic to feature based MVVM with Riverpod Jun 18, 2026
@Mayank4352 Mayank4352 mentioned this pull request Jun 20, 2026
Closed
@Mayank4352
chore: merge upstream/state_migration into state_refac_rooms (resolve…
2308ff8 
… profile dup-migration conflicts, keep feature data/repositories layout)
@M4dhav
M4dhav merged commit 97154b4 into AOSSIE-Org:state_migration Jul 8, 2026
3 of 4 checks passed
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

✅ PR Closed - Thank You, @Mayank4352!

  • If this PR was merged: Congratulations! Your contribution is now part of the project. 🚀
  • If this PR was closed without merging: Don’t worry! You can always improve it and submit again. 💪

We appreciate your effort and look forward to more contributions from you! 🤝

Mayank4352 added a commit to Mayank4352/Resonate that referenced this pull request Jul 8, 2026
@Mayank4352
chore: re-sync upstream/state_migration (post AOSSIE-Org#824 squash-m…
9795bf4 
…erge) into state_cleanup to clear PR conflict
Mayank4352 added a commit to Mayank4352/Resonate that referenced this pull request Jul 8, 2026
@Mayank4352
chore: re-sync upstream/state_migration (post AOSSIE-Org#824 squash-m…
6de739a 
…erge) into state_story to clear PR conflict
Mayank4352 added a commit to Mayank4352/Resonate that referenced this pull request Jul 8, 2026
@Mayank4352
chore: re-sync upstream/state_migration (post AOSSIE-Org#824 squash-m…
57b973f 
…erge) into state_left to clear PR conflict
Mayank4352 added a commit to Mayank4352/Resonate that referenced this pull request Jul 8, 2026
@Mayank4352
chore: re-sync upstream/state_migration (post AOSSIE-Org#824 squash-m…
28a0e0f 
…erge) into state_final to clear PR conflict
Mayank4352 added a commit to Mayank4352/Resonate that referenced this pull request Jul 8, 2026
@Mayank4352
chore: re-sync upstream/state_migration (post AOSSIE-Org#824 squash-m…
1af15d2 
…erge) into state_friends to clear PR conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@M4dhav M4dhav Awaiting requested review from M4dhav M4dhav is a code owner

Assignees

@Mayank4352 Mayank4352

Labels

enhancement New feature or request gsoc Part of Google Summer of Code season

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mayank4352 @M4dhav