Skip to content

Extend support for extracting common subexpressions#3170

Draft
dweindl wants to merge 2 commits intoAMICI-dev:mainfrom
dweindl:switch_cse
Draft

Extend support for extracting common subexpressions#3170
dweindl wants to merge 2 commits intoAMICI-dev:mainfrom
dweindl:switch_cse

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Apr 27, 2026

Extend support for extracting common subexpressions to previously unsupported functions such as sx0. Add tests.

@dweindl dweindl self-assigned this Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.49%. Comparing base (be3ed58) to head (00df75c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3170      +/-   ##
==========================================
- Coverage   78.14%   77.49%   -0.65%     
==========================================
  Files         317      317              
  Lines       20772    20778       +6     
  Branches     1484     1483       -1     
==========================================
- Hits        16232    16102     -130     
- Misses       4532     4668     +136     
  Partials        8        8              
Flag Coverage Δ
cpp 70.08% <100.00%> (-0.02%) ⬇️
cpp_python 36.92% <62.50%> (+<0.01%) ⬆️
petab 46.91% <62.50%> (+<0.01%) ⬆️
petab_sciml 15.01% <12.50%> (-0.01%) ⬇️
python 68.58% <100.00%> (-0.01%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/sdist/amici/exporters/sundials/cxxcodeprinter.py 95.79% <100.00%> (+0.22%) ⬆️
python/sdist/amici/exporters/sundials/de_export.py 96.44% <ø> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dweindl added 2 commits April 28, 2026 12:16
Extend support for extracting common subexpressions to previously unsupported
functions such as `sx0`. Add tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support extracting common subexpressions in sx0 and sx0_fixedParameters

1 participant