Repository navigation
Merge ServiceSpec podAnnotations onto rendered Infera pods. - #180
Merged
Merged
Conversation
weilei0120
requested review from
JohnQinAMD,
jiejingzhangamd,
limou102 and
xiaobochen-amd
as code owners
October 5, 2026 13:27
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
LeaderWorkerSet reconciliation retains annotations after they are removed from the service specification.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds service-level pod annotations to rendered Infera workloads.
Changes:
- Adds
ServiceSpec.PodAnnotationsand CRD schemas. - Applies annotations to standard and custom pod templates.
- Adds annotation propagation coverage.
| File | Description |
|---|---|
builders.go |
Propagates annotations to pod templates. |
builders_test.go |
Tests annotation propagation. |
inferadeployment_types.go |
Defines the new API field. |
zz_generated.deepcopy.go |
Deep-copies annotation maps. |
config/crd/bases/infera.amd.com_inferadeployments.yaml |
Updates the base CRD schema. |
helm/infera-operator/crds/infera.amd.com_inferadeployments.yaml |
Updates the Helm CRD schema. |
Files not reviewed (1)
- deploy/operator/api/v1alpha1/zz_generated.deepcopy.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| func podObjectMeta(idepName, svcName string, svc inferav1alpha1.ServiceSpec) metav1.ObjectMeta { | ||
| return metav1.ObjectMeta{ | ||
| Labels: podLabelsFor(idepName, svcName, svc), | ||
| Annotations: podAnnotationsFor(svc), |
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: weilei <leiwei12@amd.com>
Service pod labels and annotations still override the same keys, and the operator selector labels stay last so selection does not change. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: weilei <leiwei12@amd.com>
weilei0120
force-pushed
the
feat/idep-pod-annotations
branch
from
October 8, 2026 06:44
31b85d2 to
3b12d93
Compare
Service pod labels and annotations are still applied as written, and a removed key is cleared from the LeaderWorkerSet worker template. Signed-off-by: weilei <leiwei12@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: