Repository navigation
Conversation
ajassani
requested review from
JohnQinAMD,
jiejingzhangamd,
limou102 and
xiaobochen-amd
as code owners
September 22, 2026 20:46
Attention-DP splits requests across ranks, not heads. Dispatch priced on the replica-wide batch made DP=8 send an 8x payload on every rank. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Adeem Jassani <ajassani@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Adeem Jassani <ajassani@amd.com>
ajassani
force-pushed
the
aj/fix-ep-a2a-attention-dp
branch
from
September 22, 2026 20:57
e42a6d5 to
bc75476
Compare
araina-amd
self-requested a review
September 23, 2026 22:14
araina-amd
approved these changes
Sep 24, 2026
Signed-off-by: Adeem Jassani <ajassani@amd.com>
2 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attn_dpon the collective:ceil(batch / attn_dp). DP=1 is unchanged.Test plan
pytest tests/unit/projection/test_expert_parallel_comm.py(6 passed)