Skip to content

chore(dependabot): raise npm PR limit to 5 to match 4 monitored dirs#97

Open
jhfnetboy wants to merge 1 commit intomainfrom
chore/dependabot-pr-limit
Open

chore(dependabot): raise npm PR limit to 5 to match 4 monitored dirs#97
jhfnetboy wants to merge 1 commit intomainfrom
chore/dependabot-pr-limit

Conversation

@jhfnetboy
Copy link
Copy Markdown
Member

Summary

  • PR chore(deps): scope Dependabot to root + packages/*, exclude vendored submodules #89 (+ follow-up aa20272) expanded the npm directories list to 4 paths: /, /packages/*, /subgraph, /script/gasless-tests.
  • open-pull-requests-limit was kept at 1, but this limit is shared across the whole ecosystem, not per-directory. So one stuck PR in any one path blocks updates for the other three.
  • Bump npm limit 1 → 5: one slot per monitored directory + 1 buffer for cross-week stragglers.
  • github-actions block is unchanged (it still monitors only /, so 1 is correct).

Why 5 (most conservative non-blocking value)

Ecosystem Directories Worst-case grouped PRs/week New limit
npm 4 4 5 (4 + 1 buffer)
github-actions 1 1 1 (unchanged)

5 is the smallest value that:

  1. Cannot deadlock when every directory has an open PR;
  2. Tolerates one previous-week PR lingering when the next weekly run fires.

Test plan

  • Config parses (Dependabot reports via Insights → Dependency graph).
  • Next weekly run can open multiple PRs in different directories simultaneously when warranted.
  • No PR flood beyond 5 concurrent grouped PRs in npm ecosystem.

PR #89 expanded `directories` from `/` only to 4 paths
(/, /packages/*, /subgraph, /script/gasless-tests) but kept
`open-pull-requests-limit: 1`. The limit is shared across the whole
ecosystem, not per-directory, so a single stuck PR in any one path
blocks updates for the other three.

Raise to 5: one slot per monitored directory plus a buffer for the
case where a previous week's PR is still open when the next weekly
run kicks off. github-actions stays at 1 (only one directory).
@jhfnetboy jhfnetboy requested a review from fanhousanbu as a code owner April 26, 2026 05:22
@fanhousanbu
Copy link
Copy Markdown
Contributor

代码审查

通过,可直接合并

LOW — 注释中的目录数量表述
注释写 "4 directories" 但 directories 列表中还包含多个 ! 排除项(!/singleton-paymaster/** 等)。排除项不构成监控目录,注释意图清晰,但措辞略有歧义,可酌情修正。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants