Open
Conversation
Adding one more line break, avoid the error on adding new schema over the deafult file, which now is super positioning the paths part.
Collaborator
|
Thanks for the PR! |
Collaborator
|
Just wanted to let you know, that this PR didn't make it to the last release as while it fixes the issue, it breaks few existing tests and we didn't find time to go over these yet to see if something else should be done. Hopefully it'll make it to the next one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding one more line break, avoid the error on adding new schema over the deafult file, which now is super positioning the paths part.