ci: fix the bug of pr-cancel and Autobuild#56
Merged
317787106 merged 4 commits into317787106:developfrom Mar 20, 2026
Merged
Conversation
📝 WalkthroughWalkthroughCI workflow updates: CodeQL init switched to manual build-mode with explicit JDK 8 setup and an added Gradle build step; pr-cancel broadened cancelled workflows and adjusted PR-match logic for runs missing Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub event
participant Runner as Actions runner
participant SetupJava as actions/setup-java@v5
participant Gradle as Gradle (`./gradlew`)
participant CodeQL as github/codeql-action/analyze@v4
GH->>Runner: push / workflow dispatch
Runner->>SetupJava: setup JDK 8
Runner->>Gradle: ./gradlew build -x test --no-daemon
Gradle-->>Runner: build artifacts
Runner->>CodeQL: init (build-mode: manual) & analyze
CodeQL-->>Runner: analysis results
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip Migrating from UI to YAML configuration.Use the |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/pr-cancel.yml:
- Around line 39-40: The fallback when run.pull_requests is empty is too
permissive: update the isTargetPr logic so that when there are no pull_requests
you also verify the run's head ref matches the PR head ref (avoid relying on
head_sha alone). Specifically, change the check around
isTargetPr/run.pull_requests to: if run.pull_requests has items, keep the
existing some(pr => pr.number === prNumber); otherwise require the run's head
ref (e.g., run.head_branch or run.head_ref) to equal the target PR head ref
(obtainable from the PR context or from run.pull_requests[0].head.ref when
available) in addition to matching headSha; reference isTargetPr,
run.pull_requests, run.head_sha, headSha and prNumber when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b8c80237-0fce-4aad-b3ab-a2d5620ccee8
📒 Files selected for processing (2)
.github/workflows/codeql.yml.github/workflows/pr-cancel.yml
Comment on lines
+39
to
40
| const isTargetPr = !run.pull_requests?.length || run.pull_requests.some((pr) => pr.number === prNumber); | ||
| if (run.head_sha === headSha && isTargetPr) { |
There was a problem hiding this comment.
Line 39 fallback is too broad and may cancel the wrong PR run.
When run.pull_requests is empty, isTargetPr becomes true, so any run sharing the same head_sha can be canceled. Tighten the fallback by also matching the PR head ref (or other PR-unique signal).
🔧 Suggested fix
- const isTargetPr = !run.pull_requests?.length || run.pull_requests.some((pr) => pr.number === prNumber);
- if (run.head_sha === headSha && isTargetPr) {
+ const isTargetPr = run.pull_requests?.length
+ ? run.pull_requests.some((pr) => pr.number === prNumber)
+ : (run.head_sha === headSha &&
+ run.head_branch === context.payload.pull_request.head.ref);
+ if (isTargetPr) {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/pr-cancel.yml around lines 39 - 40, The fallback when
run.pull_requests is empty is too permissive: update the isTargetPr logic so
that when there are no pull_requests you also verify the run's head ref matches
the PR head ref (avoid relying on head_sha alone). Specifically, change the
check around isTargetPr/run.pull_requests to: if run.pull_requests has items,
keep the existing some(pr => pr.number === prNumber); otherwise require the
run's head ref (e.g., run.head_branch or run.head_ref) to equal the target PR
head ref (obtainable from the PR context or from run.pull_requests[0].head.ref
when available) in addition to matching headSha; reference isTargetPr,
run.pull_requests, run.head_sha, headSha and prNumber when making the change.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/coverage-upload.yml (1)
48-54: Consider pagination for robustness.The
pulls.listAPI returns paginated results (default 30 items), and.find()only searches the first page. While it's extremely unlikely to have 30+ PRs from the sameowner:branchcombination, using the paginator would make this more robust.♻️ Optional: Use paginator for complete coverage
- const { data: pulls } = await github.rest.pulls.list({ + const pulls = await github.paginate(github.rest.pulls.list, { owner: context.repo.owner, repo: context.repo.repo, state: 'all', head: `${headOwner}:${headBranch}`, + per_page: 100, }); - const pr = pulls.find((p) => p.head.sha === headSha); + const pr = pulls.find((p) => p.head.sha === headSha);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/coverage-upload.yml around lines 48 - 54, The current code calls github.rest.pulls.list and then uses pulls.find to search only the first page; replace that with the Octokit paginator to fetch all pages before searching: call github.paginate(github.rest.pulls.list, { owner: context.repo.owner, repo: context.repo.repo, state: 'all', head: `${headOwner}:${headBranch}` }) to obtain the full pulls array, then run the find for pr where p.head.sha === headSha; update the variables around github.rest.pulls.list, pulls, and pr accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/coverage-upload.yml:
- Line 33: The workflow uses actions/download-artifact@v7 which requires Node.js
24 and Actions Runner >= 2.327.1; confirm any self-hosted runners meet those
minimums or change the action to a compatible release (e.g., pin to an earlier
v3/v4 tag) to avoid breaking changes. Locate the reference to
actions/download-artifact@v7 in the workflow and either (a) add
documentation/checks and upgrade your self-hosted runners to Node.js 24 and
Runner 2.327.1+, or (b) replace the action version with a prior compatible
release to maintain backward compatibility for existing self-hosted runners.
---
Nitpick comments:
In @.github/workflows/coverage-upload.yml:
- Around line 48-54: The current code calls github.rest.pulls.list and then uses
pulls.find to search only the first page; replace that with the Octokit
paginator to fetch all pages before searching: call
github.paginate(github.rest.pulls.list, { owner: context.repo.owner, repo:
context.repo.repo, state: 'all', head: `${headOwner}:${headBranch}` }) to obtain
the full pulls array, then run the find for pr where p.head.sha === headSha;
update the variables around github.rest.pulls.list, pulls, and pr accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1fbaf6fe-5c65-4ab1-9633-b05f3652bd79
📒 Files selected for processing (2)
.github/workflows/coverage-update-baseline.yml.github/workflows/coverage-upload.yml
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/coverage-update-baseline.yml
|
|
||
| - name: Download coverage artifact | ||
| uses: actions/download-artifact@v6 | ||
| uses: actions/download-artifact@v7 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
actions/download-artifact v7 release notes
💡 Result:
actions/download-artifact@v7.0.0 release notes (highlights)
- Runtime update (important): now runs on Node.js 24 (
runs.using: node24) and requires a minimum Actions Runner version 2.327.1 (update self-hosted runners before upgrading). [1] - What changed:
- Updated GHES guidance to reference a Node 20 version. [1]
- Added Node 24 support. [1]
- Updated
@actions/artifactto address a Node.js 24punycodedeprecation. [1] - Release prep for Node 24 support. [1]
Source: GitHub release page for v7.0.0. [1]
Verify self-hosted runner compatibility with actions/download-artifact@v7.
v7 is valid and released, but introduces breaking changes: it requires Node.js 24 runtime and Actions Runner version 2.327.1 or later. If this repository uses self-hosted runners, confirm they meet the minimum version requirement before merging, as workflows will fail otherwise. GitHub-hosted runners are auto-updated and compatible. The run-id and github-token parameters remain compatible.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/coverage-upload.yml at line 33, The workflow uses
actions/download-artifact@v7 which requires Node.js 24 and Actions Runner >=
2.327.1; confirm any self-hosted runners meet those minimums or change the
action to a compatible release (e.g., pin to an earlier v3/v4 tag) to avoid
breaking changes. Locate the reference to actions/download-artifact@v7 in the
workflow and either (a) add documentation/checks and upgrade your self-hosted
runners to Node.js 24 and Runner 2.327.1+, or (b) replace the action version
with a prior compatible release to maintain backward compatibility for existing
self-hosted runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details
Summary by cubic
Fixes PR cancellation, stabilizes CodeQL with a manual Gradle build on JDK 8, and repairs coverage upload PR detection. Prevents stuck analyses and ensures coverage and CodeQL runs map to the correct PRs.
build-mode: manual, install JDK 8 viaactions/setup-java@v5, and run./gradlew build -x test --no-daemoninstead ofgithub/codeql-action/autobuild@v4.codeql.ymlandcoverage-waiting.ymlto the cancel list; treat runs with nopull_requestsas the target PR whenhead_shamatches.actions/download-artifact@v7and fix PR detection incoverage-upload.ymlby listing pulls forhead_owner:head_branchand selecting the one matchinghead_sha.Written for commit b0d34f8. Summary will update on new commits.
Summary by CodeRabbit