Skip to content

chore(example/room-kit): bump react-native-video-plugin to ^2.0.0-alpha.0#1643

Merged
ygit merged 1 commit into
mainfrom
chore/example-video-plugin-alpha-bump
May 15, 2026
Merged

chore(example/room-kit): bump react-native-video-plugin to ^2.0.0-alpha.0#1643
ygit merged 1 commit into
mainfrom
chore/example-video-plugin-alpha-bump

Conversation

@sapta100ms
Copy link
Copy Markdown
Contributor

Pairs with the newly published @100mslive/[email protected] (peer-dep on hms widened to ^2.0.0-alpha.1).

Fixes the ERESOLVE conflict that's been failing CI on the Build and Build (New Architecture) workflows since #1642:

peer @100mslive/react-native-hms@">=1.12.0 <2.0.0" from @100mslive/[email protected]
Conflicting peer dependency: @100mslive/[email protected]

After this bump:

  • video-plugin pulls from npm at 2.0.0-alpha.0
  • Its peer dep ^2.0.0-alpha.1 is satisfied by the example app's local hms tarball
  • npm install resolves cleanly

No JS or native code changes — only package.json and the regenerated package-lock.json.

…ha.0

Pairs with the video-plugin 2.0.0-alpha.0 release. Resolves the ERESOLVE
peer-dep conflict between video-plugin 1.1.4 (which pins hms to <2.0.0)
and the example app's local hms 2.0.0-alpha.1 — npm install was refusing
to proceed without --legacy-peer-deps. With this bump, the example app
and video-plugin agree on hms 2.x.
@sapta100ms sapta100ms requested a review from ygit as a code owner May 15, 2026 04:58
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 15, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@ygit ygit merged commit 130a033 into main May 15, 2026
1 of 6 checks passed
@claude
Copy link
Copy Markdown

claude Bot commented May 15, 2026

PR Review

Summary

This PR bumps @100mslive/react-native-video-plugin from 1.1.0 to ^2.0.0-alpha.0 in the room-kit example app to resolve ERESOLVE peer dependency conflicts with the new @100mslive/[email protected].

Code Quality: ✅ LGTM

The changes are minimal and focused:

  • Only touches package.json and regenerated package-lock.json
  • No JS or native code changes
  • Properly resolves the peer dependency conflict

Issues & Concerns

1. Inconsistent Version Across Codebase ⚠️

The video plugin version is inconsistent across the monorepo:

  • packages/react-native-room-kit/example/package.json: ^2.0.0-alpha.0 (this PR)
  • packages/react-native-room-kit/package.json:
    • devDependencies: 1.1.4
    • additionalDependencies: 1.1.0
  • sample-apps/VirtualBackgroundSample/package.json: 0.1.2

Recommendation: Consider updating the room-kit package devDependencies and additionalDependencies to match the alpha version for consistency. The VirtualBackgroundSample app will need updating once the alpha is stable.

2. Caret Range for Alpha Version 🤔

The PR uses ^2.0.0-alpha.0 which allows minor/patch updates. For alpha versions, this might be overly permissive.

Recommendation: Consider using exact version 2.0.0-alpha.0 (without caret) for alpha releases to avoid unexpected breaking changes, or use tilde ~2.0.0-alpha.0 to only allow patch updates.

3. Missing Documentation 📝

No CHANGELOG update or migration notes for the alpha version bump.

Recommendation: If this is intended for wider testing, consider documenting:

  • What changed in video-plugin 2.0.0-alpha.0
  • Any API changes or breaking changes
  • Testing status

Testing Considerations

  • ✅ Resolves the ERESOLVE conflict (as stated in description)
  • ⚠️ Should verify video plugin functionality still works correctly with the alpha version
  • ⚠️ Both iOS and Android should be tested to ensure no regressions

Security: ✅ No concerns

No security issues identified. This is a peer dependency resolution fix.

Conclusion

The PR successfully addresses the immediate CI failure. However, consider:

  1. Updating other packages for version consistency
  2. Using exact/tilde versioning for alpha releases
  3. Testing the video plugin functionality on both platforms before merging

Overall: Approve with minor suggestions

The core change is correct and solves the stated problem. The suggestions are for improving consistency and alpha release stability practices.

sapta100ms added a commit that referenced this pull request May 20, 2026
…ha.0 (#1644)

Follow-up to #1643. The previous PR bumped the **example app's**
video-plugin to `^2.0.0-alpha.0`, but CI's `Link react-native-hms to
room-kit` step runs from the **library directory**
(`packages/react-native-room-kit/`), not the example. The library's own
`devDependencies` and `additionalDependencies` still pinned video-plugin
`1.1.4` / `1.1.0`, which peer-deps hms `<2.0.0` and re-triggered the
same ERESOLVE conflict against the locally-packed hms `2.0.0-alpha.1`
tarball.

Two fields updated:
- `devDependencies["@100mslive/react-native-video-plugin"]`: `1.1.4` →
`^2.0.0-alpha.0`
- `additionalDependencies["@100mslive/react-native-video-plugin"]`:
`1.1.0` → `^2.0.0-alpha.0`

`package-lock.json` regenerated accordingly.

**Consumer impact:** none. `devDependencies` and the non-standard
`additionalDependencies` are not installed when customers run `npm
install @100mslive/react-native-room-kit`. This PR affects only our
repo's CI + local dev setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants