chore: bump protocol to 0.15.3 and node to 0.15.0#2229
Conversation
|
Marking as |
juan518munoz
added
the
no changelog
The newer node's `miden_validator::db::load` verifies an existing schema and fails on a missing file; `db::setup` bootstraps the database and applies migrations. The test node-builder starts from a fresh data directory, so it must use `setup`.
juan518munoz
force-pushed
the
jmunoz-protocol-0.15.2
branch
from
3bba7c8 to
4e462d8
Compare
| /// Root of the transaction-expiration script the node's network-transaction builder runs against | ||
| /// every network account. | ||
| pub(crate) static NTX_EXPIRATION_TX_SCRIPT_ROOT: LazyLock<TransactionScriptRoot> = LazyLock::new( | ||
| || { | ||
| // Mirrors the node ntx-builder's `DEFAULT_TX_EXPIRATION_DELTA` | ||
| const NTX_EXPIRATION_DELTA: u16 = 30; | ||
| let source = format!( | ||
| "begin\n push.{NTX_EXPIRATION_DELTA} exec.::miden::protocol::tx::update_expiration_block_delta\nend" | ||
| ); | ||
| CodeBuilder::new() | ||
| .compile_tx_script(source) | ||
| .expect("network-tx expiration script should compile") | ||
| .root() | ||
| }, | ||
| ); | ||
|
|
There was a problem hiding this comment.
This is not going to be used until 0xMiden/protocol#3051 gets merged and probably will change how it is implemented, so maybe we should delete it and add it when needed
There was a problem hiding this comment.
Correct me if wrong, but at the node tag this PR pins (v0.15.0-rc.3), the ntx-builder unconditionally compiles this exact expiration script and attaches it to every network transaction and 0.15.2 default empty tx-script allowlist, the network account rejects that node tx, so its notes are never consumed and the integration-test-full ntx tests hang. The allowlist is required now, not after #3051.
There was a problem hiding this comment.
It was disabled in 0xMiden/node#2173 which is included in that release candidate and will be re-introduced with 0xMiden/protocol#3050 . Though you can give it a try removing it and checking that the network txs tests will still pass
There was a problem hiding this comment.
I have removed the script in 1cba329, let's see if the CI passes without it.
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
LGTM! I agree with @SantiagoPittella that we should remove the NTX script if possible
juan518munoz
changed the title
igamigo
changed the title
0.15.3 and node to 0.15.0
4 participants
Bumps miden dependencies to protocol's
0.15.3.No significant changes made, only that network transaction tests now need the
NTX_EXPIRATION_TX_SCRIPT_ROOTto be explicitly allowed (AuthNetworkAccount::with_allowed_tx_scripts).