refactor: rename miden-tx-batch-prover crate to miden-batch#3035
Conversation
The crate no longer just proves batches: it executes, proves, and verifies them, and no longer depends on miden-tx (transaction verification moved into miden-protocol). Drop the inaccurate 'tx' and 'prover' qualifiers and name it miden-batch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
PhilippGackstatter
left a comment
There was a problem hiding this comment.
LGTM, though not sure a batch crate is meaningful enough given how little it will contain relative to the already large miden-protocol.
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I would probably rename the crate to miden-tx-batch to keep it a bit more narrow.
not sure a batch crate is meaningful enough given how little it will contain relative to the already large
miden-protocol.
I wonder if there is a good name we can pick that would combine this and the current block-prover crate. Basically, a single crate responsible for aggregating transactions at different levels (batches, blocks).
Also, some more general comments about how this could potentially evolve in the future:
With some upcoming changes in the VM, we'll change how proving works a bit. Specifically:
- The user would execute a given program to build something called
TraceProvingInputs(potentially, a better name is needed). This object will contain all the data needed to generate a proof. - Then, the user will send
TraceProvingInputsto the prover and will get anExecutionProofback.
The above step, makes provers "generic" - i.e., the prover doesn't care if it is generating a proof for a transaction, batch, or block - so, the need for dedicated provers goes away.
What we will need are the "executors" - and these would be different for transactions, batches, and blocks.
I believe the only thing currently missing in the VM for this is the ability to serialize TraceProvingInputs. cc @plafer and @huitseeker in case I'm off here.
Created 0xMiden/miden-vm#3235 |
Renames the
miden-tx-batch-provercrate tomiden-batch, per this discussion on #2998.