Skip to content

refactor: rename miden-tx-batch-prover crate to miden-batch#3035

Merged
mmagician merged 7 commits into
nextfrom
mmagician-claude/rename-batch-crate
Jun 9, 2026
Merged

refactor: rename miden-tx-batch-prover crate to miden-batch#3035
mmagician merged 7 commits into
nextfrom
mmagician-claude/rename-batch-crate

Conversation

@mmagician

@mmagician mmagician commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Renames the miden-tx-batch-prover crate to miden-batch, per this discussion on #2998.

claude added 3 commits June 3, 2026 09:24
The crate no longer just proves batches: it executes, proves, and verifies
them, and no longer depends on miden-tx (transaction verification moved into
miden-protocol). Drop the inaccurate 'tx' and 'prover' qualifiers and name it
miden-batch.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment thread CHANGELOG.md Outdated
@mmagician mmagician requested review from PhilippGackstatter and bobbinth and removed request for PhilippGackstatter June 3, 2026 09:34
@mmagician mmagician added the pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority label Jun 3, 2026
@mmagician mmagician marked this pull request as ready for review June 3, 2026 09:34

@PhilippGackstatter PhilippGackstatter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though not sure a batch crate is meaningful enough given how little it will contain relative to the already large miden-protocol.

@bobbinth bobbinth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I would probably rename the crate to miden-tx-batch to keep it a bit more narrow.

not sure a batch crate is meaningful enough given how little it will contain relative to the already large miden-protocol.

I wonder if there is a good name we can pick that would combine this and the current block-prover crate. Basically, a single crate responsible for aggregating transactions at different levels (batches, blocks).


Also, some more general comments about how this could potentially evolve in the future:

With some upcoming changes in the VM, we'll change how proving works a bit. Specifically:

  • The user would execute a given program to build something called TraceProvingInputs (potentially, a better name is needed). This object will contain all the data needed to generate a proof.
  • Then, the user will send TraceProvingInputs to the prover and will get an ExecutionProof back.

The above step, makes provers "generic" - i.e., the prover doesn't care if it is generating a proof for a transaction, batch, or block - so, the need for dedicated provers goes away.

What we will need are the "executors" - and these would be different for transactions, batches, and blocks.

I believe the only thing currently missing in the VM for this is the ability to serialize TraceProvingInputs. cc @plafer and @huitseeker in case I'm off here.

@plafer

plafer commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

I believe the only thing currently missing in the VM for this is the ability to serialize TraceProvingInputs. cc @plafer and @huitseeker in case I'm off here.

Created 0xMiden/miden-vm#3235

@mmagician mmagician added this pull request to the merge queue Jun 9, 2026
Merged via the queue into next with commit 88cd3a6 Jun 9, 2026
20 checks passed
@mmagician mmagician deleted the mmagician-claude/rename-batch-crate branch June 9, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants