chore: check against chain tip#2210
Open
SantiagoPittella wants to merge 1 commit into
Open
Conversation
Mirko-von-Leipzig
approved these changes
Jun 6, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Thanks, just some nit suggestions.
I'm still against this overall, especially in a distributed setting it can be a problem if the client alternates between different nodes which may be at different chain heights. But lets see.
Just noting my disagreement again :D
| /// | ||
| /// Returns the chain tip so callers can reuse it (e.g. in the response's pagination info) | ||
| /// without issuing a second query. | ||
| async fn chain_tip_for_range( |
Collaborator
There was a problem hiding this comment.
Maybe something like this?
Suggested change
| async fn chain_tip_for_range( | |
| async fn range_bounds_check( |
|
|
||
| ### RPC API | ||
|
|
||
| - Validated that `block_to` does not exceed the chain tip on all paginated sync endpoints ([#1866](https://github.com/0xMiden/node/issues/1866)). |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Validated that `block_to` does not exceed the chain tip on all paginated sync endpoints ([#1866](https://github.com/0xMiden/node/issues/1866)). | |
| - RPC requests whose range exceed the chain tip are now rejected ([#1866](https://github.com/0xMiden/node/issues/1866)). |
kkovaacs
approved these changes
Jun 6, 2026
Contributor
kkovaacs
left a comment
kkovaacs
left a comment
There was a problem hiding this comment.
Looks good to me % Mirko's suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1866
Adds a check for the range to not go beyond the chain tip