feat: Add slow sync strike out logic#2196
Open
sergerad wants to merge 9 commits into
Open
Conversation
sergerad
added
the
no changelog
Collaborator
Author
|
@Mirko-von-Leipzig this seems like a sensible way of doing it? Might want to tweak the capacity from 32? To lower |
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Code itself looks good; but I think there is a problem with using the block interval conceptually.
sergerad
removed
the
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #2176.
Strikes out sync subscriptions / connections when they take longer than block_time seconds to read events. Relies on capacity of the watch channels which is 32 atm.