Skip to content

"dtypes" expected a borrowed string#6268

Merged
blaginin merged 2 commits intodevelopfrom
db/dtype-borrowed
Feb 3, 2026
Merged

"dtypes" expected a borrowed string#6268
blaginin merged 2 commits intodevelopfrom
db/dtype-borrowed

Conversation

@blaginin
Copy link
Member

@blaginin blaginin commented Feb 3, 2026

No description provided.

Co-authored-by: Claude <[email protected]>
Signed-off-by: blaginin <[email protected]>
@blaginin blaginin self-assigned this Feb 3, 2026
@blaginin blaginin changed the title Add "dtypes" expected a borrowed string test "dtypes" expected a borrowed string Feb 3, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 32.49%

Comparing db/dtype-borrowed (0aa4bd3) with develop (0d0fc63)

Summary

❌ 1 regressed benchmark
✅ 1137 untouched benchmarks
⏩ 1265 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_into_canonical[(1000, 10)] 43 µs 63.7 µs -32.49%

Footnotes

  1. 1265 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Co-authored-by: Claude <[email protected]>

Signed-off-by: blaginin <[email protected]>
@blaginin blaginin added chore changelog/chore A trivial change labels Feb 3, 2026
@blaginin blaginin marked this pull request as ready for review February 3, 2026 12:59
@blaginin blaginin merged commit 1ab39e0 into develop Feb 3, 2026
54 of 59 checks passed
@blaginin blaginin deleted the db/dtype-borrowed branch February 3, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants