Skip to content

Commit 0af2693

Browse files
fengmk2codex
fengmk2
and
codex
committed
fix(run): preserve Vite production environment
Co-authored-by: GPT-5 Codex <codex@openai.com>
1 parent 44209f1 commit 0af2693

8 files changed

Lines changed: 125 additions & 32 deletions

File tree

‎Cargo.lock‎

Lines changed: 26 additions & 26 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Cargo.toml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ dunce = "1.0.5"
192192
fast-glob = "1.0.0"
193193
flate2 = { version = "=1.1.9", features = ["zlib-rs"] }
194194
form_urlencoded = "1.2.1"
195-
fspy = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "6cfa6e47a1a5fdadd215e1556766cc753603a539" }
195+
fspy = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "e68b62544b1f5853fd70de2e2f9757037eba836e" }
196196
futures = "0.3.31"
197197
futures-util = "0.3.31"
198198
glob = "0.3.2"
@@ -305,11 +305,11 @@ vite_pm_cli = { path = "crates/vite_pm_cli" }
305305
vite_setup = { path = "crates/vite_setup" }
306306
vite_shared = { path = "crates/vite_shared" }
307307
vite_static_config = { path = "crates/vite_static_config" }
308-
vite_path = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "6cfa6e47a1a5fdadd215e1556766cc753603a539" }
309-
vite_powershell = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "6cfa6e47a1a5fdadd215e1556766cc753603a539" }
310-
vite_str = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "6cfa6e47a1a5fdadd215e1556766cc753603a539" }
311-
vite_task = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "6cfa6e47a1a5fdadd215e1556766cc753603a539" }
312-
vite_workspace = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "6cfa6e47a1a5fdadd215e1556766cc753603a539" }
308+
vite_path = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "e68b62544b1f5853fd70de2e2f9757037eba836e" }
309+
vite_powershell = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "e68b62544b1f5853fd70de2e2f9757037eba836e" }
310+
vite_str = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "e68b62544b1f5853fd70de2e2f9757037eba836e" }
311+
vite_task = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "e68b62544b1f5853fd70de2e2f9757037eba836e" }
312+
vite_workspace = { git = "https://github.com/voidzero-dev/vite-task.git", rev = "e68b62544b1f5853fd70de2e2f9757037eba836e" }
313313
walkdir = "2.5.0"
314314
wax = "0.6.0"
315315
which = "8.0.0"

‎packages/cli/snap-tests/vp-run-vite-node-env/index.html‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<!doctype html>
2+
<html>
3+
<body>
4+
<script type="module" src="/main.ts"></script>
5+
</body>
6+
</html>

‎packages/cli/snap-tests/vp-run-vite-node-env/main.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
console.log(
2+
JSON.stringify({
3+
DEV: import.meta.env.DEV,
4+
MODE: import.meta.env.MODE,
5+
PROD: import.meta.env.PROD,
6+
}),
7+
);

‎packages/cli/snap-tests/vp-run-vite-node-env/package.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"name": "vp-run-vite-node-env-test",
3+
"private": true
4+
}

‎packages/cli/snap-tests/vp-run-vite-node-env/snap.txt‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
> vp build 2>&1 | grep '^NODE_ENV=' # direct build
2+
NODE_ENV="production"
3+
4+
> node -e "const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))"
5+
{"DEV":false,"MODE":"production","PROD":true}
6+
7+
> rm -rf dist
8+
> vp run build 2>&1 | grep '^NODE_ENV=' # task runner build
9+
NODE_ENV="production"
10+
11+
> node -e "const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))"
12+
{"DEV":false,"MODE":"production","PROD":true}
13+
14+
> rm -rf dist
15+
> vp run --no-cache deploy 2>&1 | grep '^NODE_ENV=' # build dependency of deploy
16+
NODE_ENV="production"
17+
18+
> node -e "const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))"
19+
{"DEV":false,"MODE":"production","PROD":true}
20+
21+
> rm -rf dist
22+
> NODE_ENV=test vp build 2>&1 | grep '^NODE_ENV=' # direct build with explicit NODE_ENV
23+
NODE_ENV="test"
24+
25+
> node -e "const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))"
26+
{"DEV":true,"MODE":"production","PROD":false}
27+
28+
> rm -rf dist
29+
> NODE_ENV=test vp run build 2>&1 | grep '^NODE_ENV=' # task runner build with explicit NODE_ENV
30+
NODE_ENV="test"
31+
32+
> node -e "const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))"
33+
{"DEV":true,"MODE":"production","PROD":false}

‎packages/cli/snap-tests/vp-run-vite-node-env/steps.json‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
{
2+
"ignoredPlatforms": ["win32"],
3+
"commands": [
4+
"vp build 2>&1 | grep '^NODE_ENV=' # direct build",
5+
"node -e \"const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))\"",
6+
"rm -rf dist",
7+
"vp run build 2>&1 | grep '^NODE_ENV=' # task runner build",
8+
"node -e \"const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))\"",
9+
"rm -rf dist",
10+
"vp run --no-cache deploy 2>&1 | grep '^NODE_ENV=' # build dependency of deploy",
11+
"node -e \"const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))\"",
12+
"rm -rf dist",
13+
"NODE_ENV=test vp build 2>&1 | grep '^NODE_ENV=' # direct build with explicit NODE_ENV",
14+
"node -e \"const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))\"",
15+
"rm -rf dist",
16+
"NODE_ENV=test vp run build 2>&1 | grep '^NODE_ENV=' # task runner build with explicit NODE_ENV",
17+
"node -e \"const fs=require('node:fs');require('./dist/assets/'+fs.readdirSync('dist/assets').find(f=>f.endsWith('.js')))\""
18+
]
19+
}

‎packages/cli/snap-tests/vp-run-vite-node-env/vite.config.ts‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
export default {
2+
build: {
3+
modulePreload: false,
4+
},
5+
run: {
6+
tasks: {
7+
build: 'vp build',
8+
'db:migrate:prod': 'node -e ""',
9+
deploy: {
10+
command: 'node -e ""',
11+
dependsOn: ['build', 'db:migrate:prod'],
12+
cache: false,
13+
},
14+
},
15+
},
16+
plugins: [
17+
{
18+
name: 'node-env',
19+
config() {
20+
console.log(`NODE_ENV=${JSON.stringify(process.env.NODE_ENV)}`);
21+
},
22+
},
23+
],
24+
};

0 commit comments

Comments
 (0)