Skip to content

Scroll data instead of widgets #111

Description

@kevinlinxc

This feature would improve our performance a lot, I'm pretty sure.

Right now, we are adding a QLabel for each new image that we get. It's a subclass of Qlabel actually, the GalleryImage: https://github.com/ubcaerodesign/codex/blob/main/gamer-gui/utils/custom_qt_classes.py#L28

This addition is expensive, it lags the UI thread and we're doing it constantly. A better way would be to just make how many GalleryImages that we can show, store all the data (in a list), and just scroll the data across the gallery images. Basically, we only have 10 images shown at once, when you scroll, it replaces the GalleryImages data with the data that we store. (prefer scroll to buttons for now, buttons would be slower to get through lots of images - see here for example of capturing scroll event).

Everything else works the same, clicking on an image lets you annotate its center and its timestamp is still right.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions