Enforce SHA-384 signature generation - #401
Closed
tim-kos wants to merge 1 commit into
Closed
Conversation
kvz
requested changes
May 18, 2026
kvz
left a comment
kvz
left a comment
Member
There was a problem hiding this comment.
Not entirely good, we at least need 256 for cdn support I think
tim-kos
commented
May 26, 2026
tim-kos
left a comment
tim-kos
left a comment
Member
Author
There was a problem hiding this comment.
Findings: none.
The SDK now hardcodes SHA-384 for Transloadit signatures and keeps the sha384: prefix in place. The unit coverage exercises the intended behavior, and I do not see docs or compatibility gaps in this diff.
Member
Author
|
Findings: none. The SDK now hardcodes SHA-384 for Transloadit signatures and keeps the |
Member
|
And we already support sha384 so will close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_calcSignature()calcSignature()returns SHA-384 signaturesWhy
API keys default to SHA-384, so allowing algorithm drift from SDK internals can cause avoidable auth failures in downstream integrations.
Fixes #400