Skip to content

th verify: increase forge spawnSync maxBuffer / avoid output overflow #8

@snissn

Description

@snissn

Context

Problem

  • th verify runs forge verify-contract via spawnSync and captures stdout/stderr.
  • Node’s default spawnSync stdout/stderr buffer can be exceeded in edge cases, causing verification to fail even if forge would otherwise succeed.

Proposal

  • Set an explicit maxBuffer when invoking spawnSync('forge', ...) (e.g. 10–20MB).
  • Consider adding a lightweight guardrail: if output is truncated/overflowed, persist a message into manifest.extensions.verification[chainId] indicating output was truncated.

Acceptance criteria

  • th verify does not fail due to buffer overflow for large forge output.
  • Verification results are still written to manifest.extensions.verification[chainId] with actionable error context.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions