Skip to content

#12144: Compile Spock extension with invokedynamic to support Groovy 6 - #12146

Open
winfriedgerlach wants to merge 1 commit into
testcontainers:mainfrom
winfriedgerlach:#12144-spock-groovy6-indy
Open

winfriedgerlach wants to merge 1 commit into
testcontainers:mainfrom
winfriedgerlach:#12144-spock-groovy6-indy

Conversation

@winfriedgerlach

@winfriedgerlach winfriedgerlach commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

See #12144: this PR lets testcontainers-spock run with Groovy 6 using groovyOptions.optimizationOptions.indy
If you prefer using @CompileStatic instead, deny this PR and use #12145 instead.

Summary by CodeRabbit

  • Performance
    • Enabled invokedynamic optimization for Groovy compilation in the Spock module. This may improve execution efficiency for affected code.
  • Other
    • No changes to public APIs or user-facing functionality are included in this update.

@winfriedgerlach
winfriedgerlach requested a review from a team as a code owner October 30, 2026 12:56
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 423193be-d60c-4f98-b01f-57ff895d1806
Commits

Reviewing files that changed from the base of the PR and between f74d167 and 79f5738.

Files selected for processing: 1
  • modules/spock/build.gradle

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

Groovy compilation in the Spock module now enables the indy optimization option.

Changes: Spock compilation

Layer / File(s) Summary
Enable invokedynamic optimization
modules/spock/build.gradle
Groovy compilation enables the indy optimization option.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related issues

  • testcontainers/testcontainers-java#12144: The issue reports the same testcontainers-spock failure on Groovy 6 and identifies the compiler option enabled here as a fix.

Suggested reviewers: eddumelendez

Merge Risk: Minimal · up to 79f57

The compiler option change appears safe to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the change: enabling invokedynamic compilation for the Spock extension to support Groovy 6.
Description check Passed The description explains the change, states the Groovy 6 compatibility objective, and references the related issue. It provides sufficient context for this small change.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modules/spock Spock Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant