From cd40d0d3b09729dda4af3ebf33ee33b90c19bd91 Mon Sep 17 00:00:00 2001 From: Ramya Rao <100975018+ramya-stripe@users.noreply.github.com> Date: Tue, 10 Nov 2026 13:33:46 -0800 Subject: [PATCH] Remove obsolete instructions to update CA bundle (#2030) * Remove CA certificates update instructions from README Removed instructions for updating bundled CA certificates. * Remove update-certs task Removed update-certs task from justfile. * Remove update_certs task and fetch_file method Removed the update_certs task and its related fetch_file method from the Rakefile. * Remove the unused curl link --- README.md | 8 -------- Rakefile | 25 ------------------------- justfile | 3 --- 3 files changed, 36 deletions(-) diff --git a/README.md b/README.md index abcbde59c..fb114978c 100644 --- a/README.md +++ b/README.md @@ -423,16 +423,8 @@ just lint # or: bundle exec rubocop ``` -Update bundled CA certificates from the [Mozilla cURL release][curl]: - -```sh -just update-certs -# or: bundle exec rake update_certs -``` - [api-keys]: https://dashboard.stripe.com/account/apikeys [connect]: https://stripe.com/connect -[curl]: http://curl.haxx.se/docs/caextract.html [idempotency-keys]: https://stripe.com/docs/api/idempotent_requests?lang=ruby [stripe-mock]: https://github.com/stripe/stripe-mock [versioning]: https://stripe.com/docs/api/versioning?lang=ruby diff --git a/Rakefile b/Rakefile index 212381e9d..aee62660b 100644 --- a/Rakefile +++ b/Rakefile @@ -7,28 +7,3 @@ task default: %i[test rubocop] Rake::TestTask.new do |t| t.pattern = "./test/**/*_test.rb" end - -desc "Update bundled certs" -task :update_certs do - require "net/http" - require "uri" - - fetch_file "https://curl.se/ca/cacert.pem", - File.expand_path("lib/data/ca-certificates.crt", __dir__) -end - -# -# helpers -# - -def fetch_file(uri, dest) - File.open(dest, "w") do |file| - resp = Net::HTTP.get_response(URI.parse(uri)) - unless resp.code.to_i == 200 - abort("bad response when fetching: #{uri}\n" \ - "Status #{resp.code}: #{resp.body}") - end - file.write(resp.body) - puts "Successfully fetched: #{uri}" - end -end diff --git a/justfile b/justfile index 96f3b76d4..0f739591a 100644 --- a/justfile +++ b/justfile @@ -28,9 +28,6 @@ lint: (format-check "--autocorrect") # offenses and only shows uncorrectable ones. format: (format-check "--autocorrect --display-only-fail-level-offenses") -update-certs: install - bundle exec rake update_certs - # run sorbet to check type definitions typecheck: install bundle exec srb tc