BeforeDeleteEvent isn't getting triggered

[jovanovicbogdan]

By extending a class AbstractRelationalEventListener<T> and registering two events onBeforeSave and onBeforeDelete the latter doesn't seem to work for me. But BeforeSaveEvent gets registered successfully.

Link to repo to reproduce: https://github.com/jovanovicbogdan/spring-data-jdbc-audit.

The tests can be found at src/test/java/dev/bogdanjovanovic/springdatajdbcaudit/ApplicationTests.java. Java 25 and docker are prerequisites to run the tests.

[schauder]

The producer you provided contains a lot of moving parts, of which the relation to the problem is not clear at all.

I therefore tried to create a minimal example to reproduce the problem, but failed, i.e. everything seems to work just fine.
See: https://github.com/schauder/jdbc-2195-events

Please provide a reproducer reduced to the minimum, either by simplifying your example or by extending my sample until it shows the described problem.

[jovanovicbogdan]

Can you please take a look at the example I've added to yours schauder/jdbc-2195-events#1?

Extending Repository instead of ListCrudRepository and adding a method to delete the user by id void deleteByUserId(Long userId); doesn't trigger the BeforeDeleteEvent. However, when method void delete(User user); is used there are no issues so I'm not sure if this is expected.

[schauder]

Ok, now I understand the issue.

You are not using deleteById, but a custom deleteByUserId.
While at the surface they are very similar for Spring Data JDBC they are actually quite different.

With the first one Spring Data JDBC does know that you are deleting by id, therefore exactly one entity will get deleted and we create an event and a callback for that.

The second is a derived query and as far as Spring Data JDBC knows you are deleting an arbitrary number of entities that happen to have the same value in a certain property.
In order to create events for these, we would first have to execute a select to load these.
We decided not do this, since in the general case these events are not needed and they cost significant resources.

I just checked and realized this is not properly documented.
I'll fix the documentation.