forked from ninja-build/ninja
-
Notifications
You must be signed in to change notification settings - Fork 1
Replace test.h with google test (or equivalent) #28
Copy link
Copy link
Open
Labels
C++98Changes that should go first in the patch series.Changes that should go first in the patch series.DevOpsThings like Continuous Integration and the likeThings like Continuous Integration and the likepatchIntended to be part of the patch series that makes up splinterIntended to be part of the patch series that makes up splinter
Metadata
Metadata
Assignees
Labels
C++98Changes that should go first in the patch series.Changes that should go first in the patch series.DevOpsThings like Continuous Integration and the likeThings like Continuous Integration and the likepatchIntended to be part of the patch series that makes up splinterIntended to be part of the patch series that makes up splinter
Type
Fields
Give feedbackNo fields configured for issues without a type.
the biggest complaint that I have about this is that the current test code doesn't tell you what the value you did get was.
Ninja justifies this in an in-code comment saying that including the actual google test library can increase compile times by as much as 20%.
Considering that Ninja takes under a minute to compile (for me, at least), I think I'd rather have the real google test...