Skip to content

Commit 25c14fb

Browse files
WilliamBergaminClaude
andauthored
fix(socket_mode): raise ValueError for an unsupported request payload (#2047)
Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
1 parent 33288b9 commit 25c14fb

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎slack_sdk/socket_mode/request.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def __init__(
3030
elif isinstance(payload, str):
3131
self.payload = {"text": payload}
3232
else:
33-
unexpected_payload_type = type(payload)
33+
unexpected_payload_type = payload.__class__
3434
raise ValueError(f"Unsupported payload data type ({unexpected_payload_type})")
3535

3636
self.accepts_response_payload = accepts_response_payload or False

‎tests/slack_sdk/socket_mode/test_request.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,7 @@ def test_to_dict_from_dict_round_trip(self):
4343
self.assertEqual(actual.type, expected.type)
4444
self.assertEqual(actual.envelope_id, expected.envelope_id)
4545
self.assertEqual(actual.payload, expected.payload)
46+
47+
def test_unsupported_payload_type(self):
48+
with self.assertRaises(ValueError):
49+
SocketModeRequest(type="slash_commands", envelope_id="abc-123", payload=123)

0 commit comments

Comments
 (0)