Skip to content

remove redundant get_* functions in repo_processor #36

Description

@maany

The idea is to incorporate the suggestion made by @snehasi in #27.
Essentially, we should create a function in repo_processor like

def get_repository_file(repo_url, file):
    ...
    ...

The function should get the file (one of meta-info.yaml, config-schema.yaml or default-data.yaml) and return it to the calling function.
In case of meta-info.yaml, it should use the augment_meta_info function to properly format the returned output.
The calling functions in simple_grid_yaml_compiler.py must be appropriately modified.

It's a good step towards improving code quality 👍

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions