update: Throw error if there is one#11
Open
OliverJAsh wants to merge 1 commit into
Open
Conversation
Beforehand, if there was no entity but there was an error, that error would not be propagated (via the callback).
Owner
Owner
|
... so it might end up passing back false or undefined. I always assume error === null on a successful result. |
Owner
|
I agree with the first block though. |
Contributor
Author
|
Hmm, it could be falsy, yes… not sure what you want to do about that? |
Owner
|
I would ignore it and normalise the output as null, so that internals are not leaked out in a success state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beforehand, if there was no entity but there was an error, that error would not be propagated (via the callback).