feat: Accept the token as the first argument to the client constructors

The other Seam SDKs take the api key as the first positional argument,
and the README showed Seam.new("your-api-key"), but every Ruby
constructor was keyword-only and raised ArgumentError on that call.

Accept the api key as the first argument to Seam.new, Seam::Http.new,
and Seam::Http::SingleWorkspace.new, and the personal access token as
the first argument to Seam::Http::WithoutWorkspace.new, with every other
option still passed by keyword. Giving the token both ways raises the
SDK's invalid options error.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SQW83gyXeUG61RDrHEky97

Author: claude

README.md

@@ -114,6 +114,9 @@ Obtain one from the Seam Console.
 # Set the `SEAM_API_KEY` environment variable
 seam = Seam.new
 
+# Pass as the first argument to the constructor
+seam = Seam.new("your-api-key")
+
 # Pass as a keyword argument to the constructor
 seam = Seam.new(api_key: "your-api-key")
 
@@ -226,7 +229,7 @@ For example:
 ```ruby
 require "seam"
 
-seam = Seam.new(api_key: "your-api-key")
+seam = Seam.new("your-api-key")
 
 locks = seam.locks.list
 
@@ -423,6 +426,9 @@ Obtain one from the Seam Console.
 # Set the `SEAM_PERSONAL_ACCESS_TOKEN` environment variable
 seam = Seam::Http::WithoutWorkspace.new
 
+# Pass as the first argument to the constructor
+seam = Seam::Http::WithoutWorkspace.new("your-personal-access-token")
+
 # Pass as a keyword argument to the constructor
 seam = Seam::Http::WithoutWorkspace.new(
   personal_access_token: "your-personal-access-token"

lib/seam.rb

@@ -10,8 +10,8 @@
 require_relative "seam/wait_for_action_attempt"
 
 module Seam
-  def self.new(**args)
-    Seam::Http.new(**args)
+  def self.new(api_key = nil, **options)
+    Seam::Http.new(api_key, **options)
   end
 
   def self.from_api_key(api_key, endpoint: nil, wait_for_action_attempt: true, timeout: nil, faraday_options: {},

lib/seam/http.rb

@@ -5,8 +5,8 @@
 
 module Seam
   module Http
-    def self.new(**args)
-      Http::SingleWorkspace.new(**args)
+    def self.new(api_key = nil, **options)
+      Http::SingleWorkspace.new(api_key, **options)
     end
 
     def self.from_api_key(api_key, endpoint: nil, wait_for_action_attempt: true, timeout: nil, faraday_options: {},

lib/seam/http_single_workspace.rb

@@ -19,10 +19,20 @@ class SingleWorkspace
       OPTION_NOT_PROVIDED = Object.new.freeze
       private_constant :OPTION_NOT_PROVIDED
 
-      def initialize(client: nil, api_key: OPTION_NOT_PROVIDED, personal_access_token: OPTION_NOT_PROVIDED,
-        workspace_id: OPTION_NOT_PROVIDED, endpoint: OPTION_NOT_PROVIDED,
+      def initialize(positional_api_key = nil, client: nil, api_key: OPTION_NOT_PROVIDED,
+        personal_access_token: OPTION_NOT_PROVIDED, workspace_id: OPTION_NOT_PROVIDED, endpoint: OPTION_NOT_PROVIDED,
         wait_for_action_attempt: OPTION_NOT_PROVIDED, timeout: OPTION_NOT_PROVIDED,
         faraday_options: OPTION_NOT_PROVIDED, faraday_retry_options: OPTION_NOT_PROVIDED)
+        unless positional_api_key.nil?
+          unless api_key.equal?(OPTION_NOT_PROVIDED)
+            raise Http::Options::SeamInvalidOptionsError.new(
+              "The api_key was given both as a positional argument and as the api_key option"
+            )
+          end
+
+          api_key = positional_api_key
+        end
+
         supplied_options = {
           api_key: api_key,
           personal_access_token: personal_access_token,

lib/seam/http_without_workspace.rb

@@ -15,9 +15,19 @@ class WithoutWorkspace
       OPTION_NOT_PROVIDED = Object.new.freeze
       private_constant :OPTION_NOT_PROVIDED
 
-      def initialize(client: nil, personal_access_token: OPTION_NOT_PROVIDED, endpoint: OPTION_NOT_PROVIDED,
-        wait_for_action_attempt: OPTION_NOT_PROVIDED, timeout: OPTION_NOT_PROVIDED,
+      def initialize(positional_personal_access_token = nil, client: nil, personal_access_token: OPTION_NOT_PROVIDED,
+        endpoint: OPTION_NOT_PROVIDED, wait_for_action_attempt: OPTION_NOT_PROVIDED, timeout: OPTION_NOT_PROVIDED,
         faraday_options: OPTION_NOT_PROVIDED, faraday_retry_options: OPTION_NOT_PROVIDED)
+        unless positional_personal_access_token.nil?
+          unless personal_access_token.equal?(OPTION_NOT_PROVIDED)
+            raise Http::Options::SeamInvalidOptionsError.new(
+              "The personal_access_token was given both as a positional argument and as the personal_access_token option"
+            )
+          end
+
+          personal_access_token = positional_personal_access_token
+        end
+
         supplied_options = {
           personal_access_token: personal_access_token,
           endpoint: endpoint,

spec/seam_client/api_key_spec.rb

@@ -22,6 +22,43 @@
       expect(device.device_id).to eq(seed["august_device_1"])
     end
 
+    it "accepts the api key as the first argument" do
+      seam = Seam.new(seed["seam_apikey1_token"], endpoint: endpoint, wait_for_action_attempt: false)
+
+      device = seam.devices.get(device_id: seed["august_device_1"])
+
+      expect(device.device_id).to eq(seed["august_device_1"])
+      expect(seam.defaults.wait_for_action_attempt).to be false
+    end
+
+    it "accepts the api key as the first argument on every constructor" do
+      [Seam::Http, Seam::Http::SingleWorkspace].each do |klass|
+        seam = klass.new(seed["seam_apikey1_token"], endpoint: endpoint)
+
+        expect(seam.devices.get(device_id: seed["august_device_1"]).device_id).to eq(seed["august_device_1"])
+      end
+    end
+
+    it "rejects an api key given both as the first argument and as an option" do
+      expect { Seam.new("seam_some_api_key", api_key: "seam_other_api_key") }.to raise_error(
+        Seam::Http::Options::SeamInvalidOptionsError,
+        "Seam received invalid options: The api_key was given both as a positional argument and as the api_key option"
+      )
+    end
+
+    it "rejects an api key given as the first argument alongside a client" do
+      expect { Seam.new("seam_some_api_key", client: Faraday.new) }.to raise_error(
+        Seam::Http::Options::SeamInvalidOptionsError,
+        /The client option cannot be used with any other option, but received: api_key/
+      )
+    end
+
+    it "treats a nil first argument as no api key" do
+      seam = Seam.new(nil, api_key: seed["seam_apikey1_token"], endpoint: endpoint)
+
+      expect(seam.devices.get(device_id: seed["august_device_1"]).device_id).to eq(seed["august_device_1"])
+    end
+
     it "returns resources with parsed attributes" do
       devices = seam.devices.list
 
@@ -44,6 +81,10 @@
         Seam.from_api_key("ey")
       end.to raise_error(Seam::Http::Auth::SeamInvalidTokenError, /JWT/)
 
+      expect do
+        Seam.new("ey")
+      end.to raise_error(Seam::Http::Auth::SeamInvalidTokenError, /JWT/)
+
       expect do
         Seam.from_api_key("seam_cst_token")
       end.to raise_error(Seam::Http::Auth::SeamInvalidTokenError, /Client Session Token/)

spec/seam_client/client_without_workspace_spec.rb

@@ -25,6 +25,20 @@
       expect(seam.workspaces.list.length).to be > 0
     end
 
+    it "accepts the personal access token as the first argument" do
+      seam = described_class.new(seed["seam_at1_token"], endpoint: endpoint)
+
+      expect(seam.workspaces.list.length).to be > 0
+    end
+
+    it "rejects a personal access token given both as the first argument and as an option" do
+      expect { described_class.new("seam_at1_token", personal_access_token: "seam_at2_token") }.to raise_error(
+        Seam::Http::Options::SeamInvalidOptionsError,
+        "Seam received invalid options: The personal_access_token was given both as a positional argument " \
+        "and as the personal_access_token option"
+      )
+    end
+
     it "accepts an injected client with request defaults" do
       client = Faraday.new