Skip to content

Peer2peer code review #2

Description

@Basir-Mohammadi

Changes Required

Hi @sajid-munawar

Nice job, you are almost there.

(Highlights) Good Points:

  • Good commit messages. ✔️
  • No linter errors. ✔️
  • Followed Github flow ✔️
  • Professional README file. ✔️
  • PR has a good title and summary ✔️

(Changes Required) Aspects to improve:

  • Please check the below comments.

[Optional] suggestions:

  • Nothing to mention.

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! 👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear
Please, remember to tag @basirking in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Capture1

  • please stick to the original design.
    Capture
  • please stick to the original design.
    alt
  • please add descriptive alt .

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions