Detect formatted React.createClass calls - #58256
Closed
OskarEichler wants to merge 1 commit into
Closed
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D118266439. |
shashikant-panchal
pushed a commit
to shashikant-panchal/react-native
that referenced
this pull request
Sep 10, 2026
Summary: The source-optimized preset enables React's display-name transform only when the exact bytes `React.createClass` are present. Valid comments or whitespace around the member access, such as `React /* comment */ . createClass(...)`, bypass the transform and omit the inferred component `displayName`, unlike the full preset path. Use the stable `createClass` identifier token as the cheap source probe while retaining the separate `createReactClass` probe. Formatting no longer changes output; unrelated token matches only enable an otherwise no-op Babel visitor. ## Changelog: [GENERAL] [FIXED] - Detect trivia-separated React.createClass calls in optimized preset configuration. Pull Request resolved: react#58256 Test Plan: - Added an optimized-source regression with comment/whitespace-separated member access. - Exact baseline omits `displayName`; the fixed transform emits `displayName: "Component"`. - Full preset Jest passes: 4/4 suites, 111/111 tests, 16 snapshots. - Fresh Flow check reports 0 errors. - Targeted no-ignore ESLint, Prettier, and `git diff --check` pass. No public API or breaking behavior change; optimized and full preset paths now agree for valid formatting. Reviewed By: GijsWeterings Differential Revision: D118266439 Pulled By: javache fbshipit-source-id: 802fe1c8cadda18931384cd5a7f6e88a63e87bad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The source-optimized preset enables React's display-name transform only when the exact bytes
React.createClassare present. Valid comments or whitespace around the member access, such asReact /* comment */ . createClass(...), bypass the transform and omit the inferred componentdisplayName, unlike the full preset path.Use the stable
createClassidentifier token as the cheap source probe while retaining the separatecreateReactClassprobe. Formatting no longer changes output; unrelated token matches only enable an otherwise no-op Babel visitor.Changelog:
[GENERAL] [FIXED] - Detect trivia-separated React.createClass calls in optimized preset configuration.
Test Plan:
displayName; the fixed transform emitsdisplayName: "Component".git diff --checkpass.No public API or breaking behavior change; optimized and full preset paths now agree for valid formatting.