Emit tvOS focus events after focus updates - #58372
Closed
sbuggay wants to merge 1 commit into
Closed
Conversation
Summary: On tvOS, the focus engine and UIKit first responder are related but distinct. The imperative focus path previously called `becomeFirstResponder` before requesting a focus-engine update. If tvOS rejected that candidate, React Native had already emitted `blur` for the currently focused view and `focus` for the candidate, leaving JavaScript event state out of sync with visual focus. Request the tvOS focus update without changing first responder first. `didUpdateFocusInContext` remains the point that promotes the selected view to first responder and emits events. Successful focus updates retain their focus and blur events, rejected updates emit neither, and non-tvOS behavior is unchanged. Changelog: [iOS][Fixed] - Prevent unsuccessful tvOS focus requests from emitting stale focus events Differential Revision: D119054149
meta-cla
Bot
added
the
CLA Signed
|
@sbuggay has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119054149. |
|
This pull request has been merged in 3e897cf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On tvOS, the focus engine and UIKit first responder are related but distinct. The imperative focus path previously called
becomeFirstResponderbefore requesting a focus-engine update. If tvOS rejected that candidate, React Native had already emittedblurfor the currently focused view andfocusfor the candidate, leaving JavaScript event state out of sync with visual focus.Request the tvOS focus update without changing first responder first.
didUpdateFocusInContextremains the point that promotes the selected view to first responder and emits events. Successful focus updates retain their focus and blur events, rejected updates emit neither, and non-tvOS behavior is unchanged.Changelog:
[iOS][Fixed] - Prevent unsuccessful tvOS focus requests from emitting stale focus events
Differential Revision: D119054149