Make Lists, Networking, and UIManager modules Flow strict-local (#57726)

Summary:

Upgrade the FlatList/SectionList list components, the networking modules (`XMLHttpRequest`, `FormData`, `RCTNetworking`, `convertRequestBody`), and the UIManager modules from `flow` to `flow strict-local`. Public type signatures are preserved exactly, so no consumers need updating; internal `any` and `Object` usages were replaced with accurate types wherever that did not change a public signature.

Two public signatures deliberately keep their original loose types behind a scoped `$FlowFixMe[unclear-type]`, because Flow's invariance rules mean any precise annotation would reject existing callers: the `headers` parameters on the `XHRInterceptor` interface (invariant indexers), and `commandArgs` on `UIManager.dispatchViewManagerCommand` (invariant array elements, which would reject callers passing an already-typed array).

Changelog: [Internal]

Reviewed By: cipolleschi, javache

Differential Revision: D113763786

Author: rubennorte

packages/react-native/Libraries/Lists/FlatList.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -78,7 +78,7 @@ type OptionalFlatListProps<ItemT> = {
    * any of your `renderItem`, Header, Footer, etc. functions depend on anything outside of the
    * `data` prop, stick it here and treat it immutably.
    */
-  extraData?: any,
+  extraData?: unknown,
   /**
    * `getItemLayout` is an optional optimizations that let us skip measurement of dynamic content if
    * you know the height of items a priori. `getItemLayout` is the most efficient, and is easy to
@@ -172,9 +172,10 @@ function numColumnsOrDefault(numColumns: ?number) {
   return numColumns ?? 1;
 }
 
-function isArrayLike(data: unknown): boolean {
-  // $FlowExpectedError[incompatible-use]
-  return typeof Object(data).length === 'number';
+function isArrayLike<ItemT>(
+  data: ?Readonly<$ArrayLike<ItemT>>,
+): implies data is Readonly<$ArrayLike<ItemT>> {
+  return data != null && typeof data.length === 'number';
 }
 
 type FlatListBaseProps<ItemT> = {
@@ -305,6 +306,7 @@ export type FlatListProps<ItemT> = Readonly<{
  *
  * Also inherits [ScrollView Props](docs/scrollview.html#props), unless it is nested in another FlatList of same orientation.
  */
+// flowlint-next-line unclear-type:off
 class FlatList<ItemT = any> extends React.PureComponent<FlatListProps<ItemT>> {
   /**
    * Scrolls to the end of the content. May be janky without `getItemLayout` prop.
@@ -404,7 +406,7 @@ class FlatList<ItemT = any> extends React.PureComponent<FlatListProps<ItemT>> {
     }
   }
 
-  getScrollableNode(): any {
+  getScrollableNode(): ?number {
     if (this._listRef) {
       return this._listRef.getScrollableNode();
     }
@@ -499,7 +501,10 @@ class FlatList<ItemT = any> extends React.PureComponent<FlatListProps<ItemT>> {
       'FlatList does not support custom data formats.',
     );
     if (numColumns > 1) {
-      invariant(!horizontal, 'numColumns does not support horizontal.');
+      invariant(
+        Boolean(horizontal) === false,
+        'numColumns does not support horizontal.',
+      );
     } else {
       invariant(
         !columnWrapperStyle,
@@ -611,11 +616,13 @@ class FlatList<ItemT = any> extends React.PureComponent<FlatListProps<ItemT>> {
   }
 
   _renderer = (
-    ListItemComponent: ?(React.ComponentType<any> | React.MixedElement),
+    ListItemComponent: ?(
+      React.ComponentType<ListRenderItemInfo<ItemT>> | React.MixedElement
+    ),
     renderItem: ?ListRenderItem<ItemT>,
     columnWrapperStyle: ?ViewStyleProp,
     numColumns: ?number,
-    extraData: ?any,
+    extraData: ?unknown,
     // $FlowFixMe[missing-local-annot]
   ) => {
     const cols = numColumnsOrDefault(numColumns);

packages/react-native/Libraries/Lists/SectionList.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -26,6 +26,7 @@ import * as React from 'react';
 const VirtualizedSectionList = VirtualizedLists.VirtualizedSectionList;
 
 type DefaultSectionT = {
+  // flowlint-next-line unclear-type:off
   [key: string]: any,
 };
 
@@ -74,7 +75,7 @@ type OptionalSectionListProps<ItemT, SectionT = DefaultSectionT> = {
    * any of your `renderItem`, Header, Footer, etc. functions depend on anything outside of the
    * `data` prop, stick it here and treat it immutably.
    */
-  extraData?: any,
+  extraData?: unknown,
   /**
    * How many items to render in the initial batch. This should be enough to fill the screen but not
    * much more. Note these items will never be unmounted as part of the windowed rendering in order
@@ -172,6 +173,7 @@ export type SectionListProps<ItemT, SectionT = DefaultSectionT> = {
  * @see https://reactnative.dev/docs/sectionlist
  */
 export default class SectionList<
+  // flowlint-next-line unclear-type:off
   ItemT = any,
   SectionT = DefaultSectionT,
 > extends React.PureComponent<SectionListProps<ItemT, SectionT>> {
@@ -226,14 +228,14 @@ export default class SectionList<
   /**
    * Provides a handle to the underlying scroll node.
    */
-  getScrollableNode(): any {
+  getScrollableNode(): ?number {
     const listRef = this._wrapperListRef && this._wrapperListRef.getListRef();
     if (listRef) {
       return listRef.getScrollableNode();
     }
   }
 
-  setNativeProps(props: Object) {
+  setNativeProps(props: {[string]: unknown, ...}) {
     const listRef = this._wrapperListRef && this._wrapperListRef.getListRef();
     if (listRef) {
       listRef.setNativeProps(props);

packages/react-native/Libraries/Lists/SectionListModern.js

@@ -14,7 +14,7 @@ type FormDataValue = string | {name?: string, type?: string, uri: string};
 type FormDataNameValuePair = [string, FormDataValue];
 
 type Headers = {[name: string]: string, ...};
-type FormDataPart =
+export type FormDataPart =
   | {
       string: string,
       headers: Headers,