fix review comments

Author: mitelg

README.md

@@ -24,7 +24,7 @@ It also contains this strict framework-specific rules (can be enabled separately
 * Check that you are not using `assertSame()` with `count($variable)` as second parameter. `assertCount($variable)` should be used instead.
 * Check that you are not using `assertEquals()` with same types (`assertSame()` should be used)
 * Check that you are not using `assertNotEquals()` with same types (`assertNotSame()` should be used)
-* When PHPStan Strict Rules' `disallowedEmpty` rule is enabled, disallow PHPUnit's `assertEmpty()` and `assertNotEmpty()` assertions as well.
+* If PHPStan Strict Rules are enabled, PHPUnit's `assertEmpty()` and `assertNotEmpty()` assertions are disallowed as well.
 
 ## How to document mock objects in phpDocs?
 

src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php

@@ -27,11 +27,11 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if ($node->isFirstClassCallable() || count($node->getArgs()) < 1) {
+		if (!($node instanceof MethodCall) && !($node instanceof StaticCall)) {
 			return [];
 		}
 
-		if (!($node instanceof MethodCall) && !($node instanceof StaticCall)) {
+		if ($node->isFirstClassCallable() || count($node->getArgs()) < 1) {
 			return [];
 		}
 

tests/Rules/PHPUnit/data/assert-empty-is-discouraged.php

@@ -8,12 +8,14 @@
 final class AssertEmptyTest extends TestCase
 {
 
-	public function test(): void
+	public function test(string $bar): void
 	{
 		$this->assertEmpty([]);
 		$this->assertNotEmpty([1]);
 		Assert::assertEmpty([]);
 		static::assertNotEmpty([1]);
+		static::assertSame('foo', $bar);
+		static::assertEquals(1, '1');
 	}
 
 }