Skip to content

Commit 4695d27

Browse files
committed
reuse helper
1 parent 6990ade commit 4695d27

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

‎src/Rules/PHPUnit/AssertEmptyIsDiscouragedRule.php‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,8 @@ public function processNode(Node $node, Scope $scope): array
5252
$errorBuilder = RuleErrorBuilder::message(sprintf('%s() is not allowed. Use more strict assertion.', $node->name->toString()))
5353
->identifier('phpunit.assertEmpty');
5454

55-
foreach ($node->getArgs() as $arg) {
56-
if ($arg->name !== null || $arg->unpack) {
57-
return [$errorBuilder->build()];
58-
}
55+
if (AssertRuleHelper::hasNamedOrUnpackedArguments($node)) {
56+
return [$errorBuilder->build()];
5957
}
6058

6159
$replacement = $this->getReplacement($scope->getNativeType($node->getArgs()[0]->value), $node->name->toLowerString() === 'assertnotempty');

0 commit comments

Comments
 (0)