Skip to content

Updated readme#46

Open
bes89 wants to merge 1 commit into
pc035860:masterfrom
bes89:patch-1
Open

Updated readme#46
bes89 wants to merge 1 commit into
pc035860:masterfrom
bes89:patch-1

Conversation

@bes89

@bes89 bes89 commented Aug 2, 2015

Copy link
Copy Markdown

added bower install highlightjs and used ---save parameter when installing packages

added bower install highlightjs and used ---save parameter when installing packages
@pc035860

pc035860 commented Aug 3, 2015

Copy link
Copy Markdown
Owner

There's no --save nor --save-dev presented at https://github.com/angular-ui/ui-router/blob/master/README.md#get-started.
I believe they meant to let the user to decide whether to add it or not?

@bes89

bes89 commented Aug 3, 2015

Copy link
Copy Markdown
Author

Whats wrong with --save? it just adds the new dependency to your package.json/bower.json.
Sure, you can add it manually....

@ethanhann

Copy link
Copy Markdown

Installing highlightjs separately wouldn't be necessary if it is listed in angular-highlightjs's bower.json file as a dependency.

@pc035860

Copy link
Copy Markdown
Owner

@ethanhann Actually, the highlight.js dependency was removed from bower.json due to #28 .

@ethanhann

Copy link
Copy Markdown

Ah, I understand the situation. Dependencies can be overridden in bower.json anyway, which is handy for allowing tools like wiredep to work, so it isn't a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants