Skip to content
This repository was archived by the owner on May 21, 2024. It is now read-only.
This repository was archived by the owner on May 21, 2024. It is now read-only.

XCM configuration review. #256

Description

@hbulgarini

@vstam1 shared the following inputs for the Trappist XCM configuration:

  • Line 62: Can't we remove Ancestry? Its never used.

  • Line 136: Could use the ConvertedConcreteId instead of ConvertedRegisteredAssetId. I can understand that the name makes more sense then ConvertedConcreteId in this case but could also create seperate type ConvertedRegisteredAssetId = ConvertedContreteId<...> to prevent code duplication. I think Gavin did change the trait bounds in 0.9.43 or still just master from Convert -> MaybeEquivalence but think that the 0.9.42 still has the old trait bounds.
    Still just a suggestion, can keep it as is.

  • Line 201: Might be able to use RockmineLocation.

  • Line 329: IMPORTANT: I would disable random users from sending arbitrary xcm messages to any destination.

  • General: Might be good to change from Rockmine to RococoAssetHub

#240 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions