Review pylint plugins and their notes.

[jenstroeger]

Currently there are only a handful of pylint plugins enabled

macaron/pyproject.toml

Lines 220 to 226 in f71d152

	load-plugins = [
	"pylint.extensions.check_elif",
	"pylint.extensions.for_any_all",
	"pylint.extensions.overlapping_exceptions",
	"pylint.extensions.set_membership",
	"pylint.extensions.typing",
	]

which is a smaller subset of all available plugins.

After enabling most of these plugins (except those that are too noisy/disagreeable/not useful right now):

load-plugins = [
    "pylint.extensions.bad_builtin",
    "pylint.extensions.broad_try_clause",
    "pylint.extensions.check_elif",
    "pylint.extensions.code_style",
    "pylint.extensions.comparison_placement",
    "pylint.extensions.confusing_elif",
    "pylint.extensions.consider_refactoring_into_while_condition",
    "pylint.extensions.consider_ternary_expression",
    "pylint.extensions.dict_init_mutate",
    # "pylint.extensions.docparams",
    # "pylint.extensions.docstyle",
    "pylint.extensions.dunder",
    "pylint.extensions.empty_comment",
    "pylint.extensions.for_any_all",
    # "pylint.extensions.magic_value",
    # "pylint.extensions.mccabe",
    "pylint.extensions.no_self_use",
    "pylint.extensions.overlapping_exceptions",
    "pylint.extensions.private_import",
    "pylint.extensions.redefined_loop_name",
    "pylint.extensions.redefined_variable_type",
    "pylint.extensions.set_membership",
    "pylint.extensions.typing",
    "pylint.extensions.while_used",
]

pylint reports a long list of notes (wouldn’t want to call them “issues”) and most of which I disabled right away:

• confusing-consecutive-elif
• consider-ternary-expression
• consider-using-assignment-expr
• empty-comment
• while-used

Then there is the rest, which may be worthwhile reviewing and discussing:

• bad-builtin
• consider-using-tuple
• no-self-use
• redefined-loop-name
• redefined-variable-type

In addition to these standard pylint plugins, I also installed perflint and, after disabling loop-invariant-statement and dotted-import-in-loop, got the following notes regarding performance:

• incorrect-dictionary-iterator
• use-dict-comprehension
• use-list-comprehension
• use-list-copy
• use-tuple-over-list which is similar to pylint’s own consider-using-tuple