Skip to content

Commit 5adc909

Browse files
authored
Run tests with PHP 8.5 and fix phpstan issue resolved by Symfony 7.4 (#41)
1 parent c2ed624 commit 5adc909

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.github/workflows/tests.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@ jobs:
99
strategy:
1010
fail-fast: true
1111
matrix:
12-
php: [8.2, 8.3, 8.4]
13-
symfony: [^6.4, false]
12+
php: [8.2, 8.3, 8.4, 8.5]
13+
symfony: [false]
1414
dependency: [stable]
1515
include:
16+
- { php: 8.2, symfony: ^6.4 , dependency: stable }
1617
- { php: 8.4, symfony: ^7.4, dependency: highest }
17-
- { php: 8.4, symfony: ^8.0, dependency: highest }
18+
- { php: 8.4, symfony: false, dependency: highest }
1819

1920
env:
2021
SYMFONY_REQUIRE: ${{ matrix.symfony }}

src/OpenAIBundle.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use OpenAI\Client;
88
use OpenAI\Contracts\ClientContract;
99
use OpenAI\Factory;
10-
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
1110
use Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator;
1211
use Symfony\Component\DependencyInjection\ContainerBuilder;
1312
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
@@ -23,7 +22,6 @@ final class OpenAIBundle extends AbstractBundle
2322
public function configure(DefinitionConfigurator $definition): void
2423
{
2524
$root = $definition->rootNode();
26-
assert($root instanceof ArrayNodeDefinition);
2725
$children = $root->children();
2826
$children
2927
->scalarNode('api_key')

0 commit comments

Comments
 (0)