nmfspalette color names not matching NOAA branding guide

[Andrea-Havron-NOAA]

I followed the link to the NOAA Fisheries Branding guide to view colors and get color names for a presentation I am working on. Currently the names between the branding guilde don't always match up with the names in nmfspalette. For example, the nmfspalette color, reflexblue is now called NOAA SKY.

Possible solutions:

• Create a lookup table that matches the NOAA brand name to nmfspalette name so older code using the original names still work. This might be a good option if the NOAA brand names are frequently updated.
• Update the nmfspalette names but include code that converts the old name to the new name. The code could possibly throw a deprecated warning as well.

I think it would also be useful to add a get_nmfs_colors() function that returns all nmfspalette color names with their hex code. Also, a display_nmfs_color() function could return scales::show_col(nmfs_cols("name")) to plot individual colos.

I'd be happy to work on this and develop a PR with changes. I have free time in about a month.

[sbreitbart-NOAA]

Hi @Andrea-Havron-NOAA,

Thank you for raising these points and offering to contribute to nmfspalette! I have a question and some suggestions, below, and would welcome your contributions to the package.

• Regarding your point about color names changing: can you please provide an example where the nmfspalette names don't align with the branding guide names? The nmfs_colors vector contains original and updated color names and hex codes (see line 75 in particular). Is this approach causing issues, or are you proposing to improve it?

• I like your idea about developing a get_nmfs_colors() function. I'd prefer naming it something like all_nmfs_colors() to align with the all_nmfs_palettes() function, which is closely related to it.

• Re: your idea about developing a display_nmfs_color() function: what do you think about expanding the functionality of nmfs_cols() instead? This function already returns the hex code for a color, and I think it would be a natural improvement to return an image of the color itself alongside the hex code.

[sbreitbart-NOAA]

@Andrea-Havron-NOAA pinging you in case this fell off your radar 🙂