Skip to content

Fix MSVC compiler warning - #341

Open
Jojo-Schmitz wants to merge 1 commit into
musescore:mainfrom
Jojo-Schmitz:compiler-warning
Open

Jojo-Schmitz wants to merge 1 commit into
musescore:mainfrom
Jojo-Schmitz:compiler-warning

Conversation

@Jojo-Schmitz

Copy link
Copy Markdown
Contributor

reg.: 'muse::dock::sizeInRange': unreferenced function with internal linkage has been removed (C4505)

reg.: 'muse::dock::sizeInRange': unreferenced function with internal linkage has been removed (C4505)
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: musescore/muse_framework/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 109fff61-efec-4970-9eed-6c63183b696b
📥 Commits

Reviewing files that changed from the base of the PR and between b1f5a4b and c75b6cc.

📒 Files selected for processing (1)
  • framework/dockwindow_v2/internal/dockbase.cpp

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change wraps the sizeInRange helper in a disabled-compilation block. adjustSizeByConstraints remains enabled.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to c75b6

The change disables the unreferenced helper without breaking callers in the reviewed code. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the warning and affected function, but it omits the required issue reference, change motivation, and repository checklist. The build configuration section is also absent. Add a “Resolves” issue number or link, a short description of the change and its motivation, and complete the applicable checklist items from the template. Include the build configuration section if needed.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix for an MSVC compiler warning, which matches the pull request’s change to address warning C4505.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant