From dc8ec72f56d7bbd41ae52e2ac707e1ead682463e Mon Sep 17 00:00:00 2001 From: Jan Roesner Date: Thu, 23 Oct 2014 14:38:29 +0200 Subject: [PATCH 1/2] Calling appear() on multiple DOM objects caused wrong $disappeared calculation. The reason was, that $prior_appeared did not persist correctly on case appear() was called on more that one selector. Simply fixed by making $prior_appeared's to persist by pushing them instead of setting them. --- jquery.appear.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jquery.appear.js b/jquery.appear.js index e4558fc..4cd91a0 100644 --- a/jquery.appear.js +++ b/jquery.appear.js @@ -34,7 +34,7 @@ var $disappeared = $prior_appeared.not($appeared); $disappeared.trigger('disappear', [$disappeared]); } - $prior_appeared = $appeared; + $prior_appeared.push($appeared); } } From 7524e90d70e2c298ef8b2c6d3901880ef5c1ff37 Mon Sep 17 00:00:00 2001 From: Jan Roesner Date: Thu, 23 Oct 2014 15:22:46 +0200 Subject: [PATCH 2/2] $prior_appeared is initially null which causes an error. Fixed. --- jquery.appear.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/jquery.appear.js b/jquery.appear.js index 4cd91a0..83125c2 100644 --- a/jquery.appear.js +++ b/jquery.appear.js @@ -34,7 +34,9 @@ var $disappeared = $prior_appeared.not($appeared); $disappeared.trigger('disappear', [$disappeared]); } - $prior_appeared.push($appeared); + if(!!$prior_appeared){ + $prior_appeared.push($appeared); + } } }