From e465e22612df00ff9bca0dd4d29deb0a7bb62ccc Mon Sep 17 00:00:00 2001 From: Alexandre de Souza Date: Wed, 17 Jun 2026 16:51:38 -0300 Subject: [PATCH 1/3] Deprecate `ReqAthena` --- lib/assets/connection_cell/main.js | 114 -------------------------- lib/assets/sql_cell/main.js | 20 ----- lib/kino_db.ex | 1 - lib/kino_db/connection_cell.ex | 65 +-------------- lib/kino_db/sql_cell.ex | 9 -- mix.exs | 1 - test/kino_db/connection_cell_test.exs | 93 --------------------- test/kino_db/sql_cell_test.exs | 84 ------------------- 8 files changed, 1 insertion(+), 386 deletions(-) diff --git a/lib/assets/connection_cell/main.js b/lib/assets/connection_cell/main.js index 7cfb8fd..6289a6f 100644 --- a/lib/assets/connection_cell/main.js +++ b/lib/assets/connection_cell/main.js @@ -538,113 +538,6 @@ export function init(ctx, info) { `, }; - const AthenaForm = { - name: "AthenaForm", - - components: { - BaseInput: BaseInput, - BaseSecret: BaseSecret, - }, - - props: { - fields: { - type: Object, - default: {}, - }, - helpBox: { - type: String, - default: "", - }, - hasAwsCredentials: { - type: Boolean, - default: false, - }, - }, - - methods: { - areFieldsEmpty(currentField, otherField) { - if (currentField === "" && otherField === "") { - return true; - } - - return false; - }, - }, - - template: ` -
- - -
-
- - -
-
- - - -
- - `, - }; - const BigQueryForm = { name: "BigQueryForm", @@ -950,7 +843,6 @@ export function init(ctx, info) { DefaultSQLForm: DefaultSQLForm, SQLServerForm: SQLServerForm, BigQueryForm: BigQueryForm, - AthenaForm: AthenaForm, ClickhouseForm: ClickhouseForm, }, @@ -988,7 +880,6 @@ export function init(ctx, info) { - @@ -1008,7 +899,6 @@ export function init(ctx, info) { { label: "SQLite", value: "sqlite" }, { label: "DuckDB", value: "duckdb" }, { label: "Google BigQuery", value: "bigquery" }, - { label: "AWS Athena", value: "athena" }, { label: "Snowflake", value: "snowflake" }, { label: "Clickhouse", value: "clickhouse" }, { label: "SQL Server", value: "sqlserver" }, @@ -1037,10 +927,6 @@ export function init(ctx, info) { return this.fields.type === "bigquery"; }, - isAthena() { - return this.fields.type === "athena"; - }, - isSQLServer() { return this.fields.type === "sqlserver"; }, diff --git a/lib/assets/sql_cell/main.js b/lib/assets/sql_cell/main.js index d5ee136..f62d375 100644 --- a/lib/assets/sql_cell/main.js +++ b/lib/assets/sql_cell/main.js @@ -228,14 +228,6 @@ export function init(ctx, payload) { inputClass="input input--xs" :inline /> -