Repository navigation
Conversation
Replace the unconditional refresh(False) after closing Preferences with a broad effective-dirty check, per maintainer feedback on linuxmint#1105 ('overly broad than explicitly narrow'). - PreferencesWindow marks its session dirty on any GSettings 'changed' signal during the window lifetime (handler connected at init and disconnected on destroy), and on a successful automatic-upgrade touchfile state transition. - No-op open/close (no effective mutation) no longer refreshes. - Restart precedence preserved: app_restart_required still restarts without a preliminary refresh. - Export blacklist and failed/reverted automation changes stay clean. Hermetic characterization harness: test_preferences_dirty_state.py. Closes rationale for linuxmint#603; supersedes closed PR linuxmint#1105 scope.
Member
|
My feedback was meant to indicate this is not necessary at all, not that I wanted it changed or improved. This is overkill. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #603
Replacement for the closed #1105, revised per maintainer feedback:
Verification:
test_preferences_dirty_state.py: broad signal, no-op close, destroy disconnect, restart precedence, automation transition.py_compile;git diff --check.AI-assisted contribution; author reviewed and verified all changes.