Skip to content

feat(ReferenceFrame): velocity of a trajectory in a frame via derivVec - #1606

Closed
zhikaip wants to merge 2 commits into
masterfrom
frame_derivVec
Closed

feat(ReferenceFrame): velocity of a trajectory in a frame via derivVec#1606
zhikaip wants to merge 2 commits into
masterfrom
frame_derivVec

Conversation

@zhikaip

@zhikaip zhikaip commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #1592: reads the velocity of a point trajectory off a frame's axes as a
frame.Vector, using derivVec.

  • Moves ReferenceFrame.lean into ReferenceFrame/Basic.lean so the folder can grow.
  • Adds ReferenceFrame/Velocity.lean with velocityComponents, its vanishing for a
    trajectory at rest, and the identification of IsInertial.velocity with the time
    derivative of the origin.
  • Adds the spec lemma IsInertial.origin_vsub to Basic.lean and drops a transitive
    import.
  • Records the observer-measured velocity (derivative of the coordinate components) as a
    TODO; it needs regularity of frame.basis in general.
  • Updates the API map: one new done entry, the origin-velocity requirement marked done, the
    reference-points half split out and left open.

🤖 Generated with Claude Code

zhikaip and others added 2 commits September 1, 2026 22:50
Add ReferenceFrame/Velocity.lean with `velocityComponents`, the velocity of a
trajectory read off a frame's axes as a `frame.Vector`, its vanishing for a
trajectory at rest, and its value for an inertial frame's own origin. Identify
`IsInertial.velocity` with the time derivative of the origin
(`IsInertial.derivVec_origin`), using a new spec lemma `IsInertial.origin_vsub`
in Basic.lean. Record the observer-measured velocity as a TODO and update the
API map. Drop a transitive Mathlib import from Basic.lean.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added the medium label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

@zhikaip zhikaip added the WIP Currently being worked on, not ready for merge label Sep 2, 2026
@zhikaip
zhikaip marked this pull request as draft September 2, 2026 17:00
@zhikaip

zhikaip commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

was trying to find an application for derivVec, but I overestimated claude's capabilities to come up with something coherent. To design this properly will require more thought so closing this for now. Apologies for noise

@zhikaip zhikaip closed this Sep 2, 2026
@zhikaip
zhikaip deleted the frame_derivVec branch September 2, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium t-space-and-time WIP Currently being worked on, not ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant