Skip to content

chore: rename CoAlg{Hom,Equiv}Class.toCoAlg{Hom,Equiv} as CoAlg{Hom,Equiv}.ofClass - #43576

Open
grunweg wants to merge 17 commits into
leanprover-community:masterfrom
grunweg:even-more-coercions
Open

chore: rename CoAlg{Hom,Equiv}Class.toCoAlg{Hom,Equiv} as CoAlg{Hom,Equiv}.ofClass#43576
grunweg wants to merge 17 commits into
leanprover-community:masterfrom
grunweg:even-more-coercions

Conversation

@grunweg

@grunweg grunweg commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

and rename affected lemmas accordingly.

Following item (2) in #31365, the definition which implements the coercion from a morphism class FooHomClass to FooHoms should be called FooHom.ofClass.

This makes two more classes follow this pattern.


Open in Gitpod

@github-actions github-actions Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 8, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 8, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

This PR/issue depends on:

@grunweg
grunweg force-pushed the even-more-coercions branch from 534b42f to d5602e6 Compare September 8, 2026 22:34
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

PR summary 2465fae17f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ _root_.AlgEquiv.ofClass
+ _root_.AlgHom.ofClass
+ _root_.AlgHomClass.linearMapOfClass_ofClass
+ _root_.CoAlgHom.ofClass
+ _root_.CoalgEquiv.ofClass
+ apply_ofClass_symm_apply
+ coe_coAlgHomOfClass
+ coe_linearMapOfClass
+ linearMapOfClass_injective
+ ofClass_symm_apply_apply
+ toCoAlgHom
+ toCoalgHom_eq_ofClass
+ toLinearMap_eq_ofClass
+ toRingHom_ofClass
++++ coe_ofClass
++++---- coe_coe
- _root_.AlgHomClass.toLinearMap_toAlgHom
- toCoalgHom

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 2465fae17f
Reference commit 38f65a093a

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant