Skip to content

Client tests are never run #560

@AntoineGautier

Description

@AntoineGautier

The client tests are launched at https://github.com/lbl-srg/ctrl-flow-dev/blob/main/.github/workflows/client-tests.yml#L38 using CI=true npm test which resolves to react-app-rewired test --passWithNoTests.
This is CRA's test runner — it ignores jest.config.ts and only reads jest config from package.json's "jest" key – and there is no such key. The actual tests are in client/tests/, but CRA defaults to looking in src/.
So, logically there are no tests found, even with changes in client code since previous commit: https://github.com/lbl-srg/ctrl-flow-dev/actions/runs/23608937777/job/68759233841#step:5:9

This situation is existing since early commits, such as edb018c.

Client tests are silently ignored in the CI workflow since the beginning.

@JayHuLBL I have no clue why we have such a setup. Do you?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions