Skip to content

cleanup: re-enable parallel tests #361

Description

@mjudeikis

After #351 was merged, the parallel test code was left in a bit of a not-ideal state.
We should come back and clean it.

Look for the issue link in the code for more details.

The problem here was the after bind login context switches, and in the parallel tests, this means - the overridden context.

Activity

  1. coderabbitai commented on Nov 5, 2025

    @coderabbitai

    A summary of the changes CodeRabbit can apply:

    • Replace the shared WorkDir usage with a per-test temporary directory in test/e2e/framework/kcp.go (change wsKubeconfigPath from filepath.Join(WorkDir, ws.Name+".kubeconfig") to filepath.Join(t.TempDir(), ws.Name+".kubeconfig")) to eliminate kubeconfig file races and re-enable safe parallel tests.

    • Update test/e2e/framework/kcp.go to write the workspace kubeconfig into a per-test temporary directory by replacing WorkDir with t.TempDir() for wsKubeconfigPath, ensuring kubeconfig files are created in isolated temp locations.

    • ✅ Create PR with these edits
    • 📋 Get copyable edits
  2. mengliwg commented on Aug 25, 2026

    @mengliwg

    Discussed in planning, we need to recheck if this is still needed

  3. self-assigned this
    on Aug 26, 2026
  4. moved this from Backlog to In Progress in Platform Mesh & Kube Projects - Backlogon Aug 26, 2026
  5. xrstf commented on Aug 26, 2026

    @xrstf
    Contributor

    I am trying to reproduce the issue, but when I check out the original merge commit (640871f) and re-enable the t.Parallel(), the contrib-kcp tests pass consistently. I am running rm -rf .kcp && make test-e2e-contrib-kcp (in more recent versions of kbind you can leave out the rm since it was made part of the Makefile).

  6. xrstf commented on Sep 8, 2026

    @xrstf
    Contributor

    Actually this was me having an .env file that forced parallelism to 1. :D

  7. moved this from Done to In Progress in Platform Mesh & Kube Projects - Backlogon Sep 9, 2026
  8. moved this from In Progress to Blocked/Waiting in Platform Mesh & Kube Projects - Backlogon Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions